From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Swamy Gowda <swamy@virident.com>,
linux-kernel@vger.kernel.org, Brice.Goglin@inria.fr,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] release mmap_sem before starting migration (Was Re: Need to take mmap_sem lock in move_pages.
Date: Thu, 5 Feb 2009 10:15:03 +0900 [thread overview]
Message-ID: <20090205101503.b1fd7df6.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0902041037150.19633@qirst.com>
On Wed, 4 Feb 2009 10:39:19 -0500 (EST)
Christoph Lameter <cl@linux-foundation.org> wrote:
> On Wed, 4 Feb 2009, KAMEZAWA Hiroyuki wrote:
>
> > mmap_sem can be released after page table walk ends.
>
> No. read lock on mmap_sem must be held since the migrate functions
> manipulate page table entries. Concurrent large scale changes to the page
> tables (splitting vmas, remapping etc) must not be possible.
>
Just for clarification:
1. changes in page table is not problem from the viewpoint of kernel.
(means no panic, no leak,...)
2. But this loses "atomic" aspect of migration and will allow unexpected
behaviors.
(means the page-mapping status after sys_move may not be what user expects.)
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-05 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <28631E6913C8074E95A698E8AC93D091B21561@caexch1.virident.info>
[not found] ` <20090204183600.f41e8b7e.kamezawa.hiroyu@jp.fujitsu.com>
[not found] ` <20090204184028.09a4bbae.kamezawa.hiroyu@jp.fujitsu.com>
2009-02-04 9:55 ` KAMEZAWA Hiroyuki
2009-02-04 15:39 ` Christoph Lameter
2009-02-05 1:15 ` KAMEZAWA Hiroyuki [this message]
2009-02-05 12:23 ` Swamy Gowda
2009-02-05 13:23 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205101503.b1fd7df6.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=Brice.Goglin@inria.fr \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=swamy@virident.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox