From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 540D66B003D for ; Wed, 4 Feb 2009 00:26:10 -0500 (EST) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n145Q7ZL007417 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Wed, 4 Feb 2009 14:26:07 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 5A7E845DE61 for ; Wed, 4 Feb 2009 14:26:07 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 060A645DE57 for ; Wed, 4 Feb 2009 14:26:07 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id D97F0E38002 for ; Wed, 4 Feb 2009 14:26:06 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 808721DB803E for ; Wed, 4 Feb 2009 14:26:06 +0900 (JST) Date: Wed, 4 Feb 2009 14:24:55 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [-mm patch] Show memcg information during OOM (v3) Message-Id: <20090204142455.83c38ad6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090204033750.GB4456@balbir.in.ibm.com> References: <20090203172135.GF918@balbir.in.ibm.com> <4988E727.8030807@cn.fujitsu.com> <20090204033750.GB4456@balbir.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: balbir@linux.vnet.ibm.com Cc: Li Zefan , Andrew Morton , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "linux-mm@kvack.org" List-ID: On Wed, 4 Feb 2009 09:07:50 +0530 Balbir Singh wrote: > > > +} > > > + > > > #endif /* CONFIG_CGROUP_MEM_CONT */ > > > > > > > > +void mem_cgroup_print_oom_info(struct mem_cgroup *memcg, struct task_struct *p) > > > +{ > > > + struct cgroup *task_cgrp; > > > + struct cgroup *mem_cgrp; > > > + /* > > > + * Need a buffer on stack, can't rely on allocations. The code relies > > > > I think it's in .bss section, but not on stack, and it's better to explain why > > the static buffer is safe in the comment. > > > > Yes, it is no longer on stack, in the original patch it was. I'll send > an updated patch > In the newest mmotm, OOM kill message is following. == Feb 4 13:16:28 localhost kernel: [ 249.338911] malloc2 invoked oom-killer: gfp_mask=0xd0, order=0, oomkilladj=0 Feb 4 13:16:28 localhost kernel: [ 249.339018] malloc2 cpuset=/ mems_allowed=0 Feb 4 13:16:28 localhost kernel: [ 249.339023] Pid: 3459, comm: malloc2 Not tainted 2.6.29-rc3-mm1 #1 Feb 4 13:16:28 localhost kernel: [ 249.339185] Call Trace: Feb 4 13:16:28 localhost kernel: [ 249.339202] [] ? _spin_unlock+0x26/0x2a Feb 4 13:16:28 localhost kernel: [ 249.339210] [] oom_kill_process+0x99/0x272 Feb 4 13:16:28 localhost kernel: [ 249.339214] [] ? select_bad_process+0x9d/0xfa Feb 4 13:16:28 localhost kernel: [ 249.339219] [] mem_cgroup_out_of_memory+0x65/0x82 Feb 4 13:16:28 localhost kernel: [ 249.339224] [] __mem_cgroup_try_charge+0x14c/0x196 Feb 4 13:16:28 localhost kernel: [ 249.339229] [] mem_cgroup_charge_common+0x47/0x72 Feb 4 13:16:28 localhost kernel: [ 249.339234] [] mem_cgroup_newpage_charge+0x3e/0x4f Feb 4 13:16:28 localhost kernel: [ 249.339239] [] handle_mm_fault+0x214/0x761 Feb 4 13:16:28 localhost kernel: [ 249.339244] [] do_page_fault+0x248/0x25f Feb 4 13:16:28 localhost kernel: [ 249.339249] [] page_fault+0x1f/0x30 Feb 4 13:16:28 localhost kernel: [ 249.339260] Task in /group_A/01 killed as a result of limit of /group_A Feb 4 13:16:28 localhost kernel: [ 249.339264] memory: usage 39168kB, limit 40960kB, failcnt 1 Feb 4 13:16:28 localhost kernel: [ 249.339266] memory+swap: usage 40960kB, limit 40960kB, failcnt 15 == Task in /group_A/01 is killed by mem+swap limit of /group_A. Yeah, very nice look :) thank you. BTW, I wonder can't we show the path of mount point ? /group_A/01 is /cgroup/group_A/01 and /group_A/ is /cgroup/group_A/ on this system. Very difficult ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org