From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
MinChan Kim <minchan.kim@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
riel@redhat.com
Subject: Re: Question: Is zone->prev_prirotiy used ?
Date: Fri, 23 Jan 2009 12:22:39 +0900 (JST) [thread overview]
Message-ID: <20090124122053.34E5.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20090122090657.7c1d7b56.kamezawa.hiroyu@jp.fujitsu.com>
> > Kamezawa-san, does its variable prevent your development?
> > if so, I don't oppose removing.
>
> Hmm, I tried to fix/clean up hierarchical-memory-reclaim + split-LRU and
> wondered where prev_priority should be recorded (hierarchy root or local or..)
> and found prev_priority is not used.
>
> IMHO, LRU management is too complex to keep unnecessary code maintained just
> because it may be used in future. I personally like to rewrite better new code
> rather than reuse old ruins.
I can't oppose maintenar's opinion ;)
ok, I'll make the patch next week.
>
> But I'm not in hurry. I just wanted to confirm.
>
> BTW, I noticed mem_cgroup_calc_mapped_ratio() is not used, either ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-01-23 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 6:52 KAMEZAWA Hiroyuki
2009-01-21 7:17 ` MinChan Kim
2009-01-21 23:54 ` KOSAKI Motohiro
2009-01-22 0:06 ` KAMEZAWA Hiroyuki
2009-01-22 0:15 ` MinChan Kim
2009-01-23 3:22 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090124122053.34E5.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox