From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 9DD9B6B0044 for ; Fri, 23 Jan 2009 08:44:31 -0500 (EST) Date: Fri, 23 Jan 2009 14:44:23 +0100 From: Nick Piggin Subject: Re: [patch] SLQB slab allocator Message-ID: <20090123134423.GI19986@wotan.suse.de> References: <20090121143008.GV24891@wotan.suse.de> <1232613933.11429.127.camel@ymzhang> <20090123090042.GB19986@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: "Zhang, Yanmin" , Pekka Enberg , Linux Memory Management List , Linux Kernel Mailing List , Andrew Morton , Lin Ming , Christoph Lameter List-ID: On Fri, Jan 23, 2009 at 01:34:49PM +0000, Hugh Dickins wrote: > On Fri, 23 Jan 2009, Nick Piggin wrote: > > > > ... Would you be able to test with this updated patch > > (which also includes Hugh's fix ... > > In fact not: claim_remote_free_list() still has the offending unlocked > + VM_BUG_ON(!l->remote_free.list.head != !l->remote_free.list.tail); Doh, thanks. Turned out to still miss a few cases where it wasn't checking for memoryless nodes (Andi explains why I didn't see it with x86-64: because it handles the case differently and assigns the default node to the nearest one with memory. I think). Working on a new version, so I've definitely got your bug covered now :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org