From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [memcg BUG] NULL pointer dereference wheng rmdir
Date: Mon, 19 Jan 2009 18:49:57 +0900 [thread overview]
Message-ID: <20090119184957.91cda7ad.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <49744BC8.2040500@cn.fujitsu.com>
On Mon, 19 Jan 2009 17:45:44 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > On Mon, 19 Jan 2009 17:15:05 +0800
> > Li Zefan <lizf@cn.fujitsu.com> wrote:
> >
> >> note: rmdir[11520] exited with preempt_count 1
> >> ===========================================================================
> >>
> >>
> >> And I've confirmed it's because (zone == NULL) in mem_cgroup_force_empty_list():
> >>
> >>
> > Hmm, curious. it will be
> >
> > ==
> > for_each_node_state(nid, N_POSSIBLE)
> > for (zid = 0; zid < MAX_NR_ZONES; zid++)
> > zone = &NODE_DATA(nid)->node_zones[zid];
> >
> > ==
> >
> > And, from this message,
> >
> > Unable to handle kernel NULL pointer dereference (address 0000000000002680)
> >
> > NODE_DATA(nid) seems to be NULL.
> >
> > Hmm...could you try this ? Thank you for nice test, very helpful.
>
> The patch fixes the bug. :)
>
> Tested-by: Li Zefan <lizf@cn.fujitsu.com>
>
Thx, I'll forward to Andrew Morton.
-Kame
> > -Kame
> > ==
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > N_POSSIBLE doesn't means there is memory...and force_empty can
> > visit invalud node which have no pgdat.
> >
> > To visit all valid nodes, N_HIGH_MEMRY should be used.
> >
> > Reporetd-by: Li Zefan <lizf@cn.fujitsu.com>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > ---
> > mm/memcontrol.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: mmotm-2.6.29-Jan16/mm/memcontrol.c
> > ===================================================================
> > --- mmotm-2.6.29-Jan16.orig/mm/memcontrol.c
> > +++ mmotm-2.6.29-Jan16/mm/memcontrol.c
> > @@ -1724,7 +1724,7 @@ move_account:
> > /* This is for making all *used* pages to be on LRU. */
> > lru_add_drain_all();
> > ret = 0;
> > - for_each_node_state(node, N_POSSIBLE) {
> > + for_each_node_state(node, N_HIGH_MEMORY) {
> > for (zid = 0; !ret && zid < MAX_NR_ZONES; zid++) {
> > enum lru_list l;
> > for_each_lru(l) {
> >
> >
> >
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-19 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 9:15 Li Zefan
2009-01-19 9:33 ` KAMEZAWA Hiroyuki
2009-01-19 9:45 ` Li Zefan
2009-01-19 9:49 ` KAMEZAWA Hiroyuki [this message]
2009-01-19 9:59 ` Balbir Singh
2009-01-19 9:55 ` [BUGFIX][PATCH] memcg: NULL pointer dereference at rmdir on some NUMA systems KAMEZAWA Hiroyuki
2009-01-19 22:26 ` KOSAKI Motohiro
2009-01-20 0:00 ` KAMEZAWA Hiroyuki
2009-01-20 1:08 ` [BUGFIX][PATCH] memcg: NULL pointer dereference at rmdir on some NUMA systems v2 KAMEZAWA Hiroyuki
2009-01-20 1:48 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119184957.91cda7ad.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox