From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id BB0126B0055 for ; Thu, 15 Jan 2009 21:23:21 -0500 (EST) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n0G2NH3s018415 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 16 Jan 2009 11:23:19 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 052BD45DE51 for ; Fri, 16 Jan 2009 11:23:17 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id C36E745DE4F for ; Fri, 16 Jan 2009 11:23:16 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id AD40F1DB803C for ; Fri, 16 Jan 2009 11:23:16 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 4FCADE08004 for ; Fri, 16 Jan 2009 11:23:16 +0900 (JST) Date: Fri, 16 Jan 2009 11:22:11 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 3/4] memcg: hierarchical reclaim by CSS ID Message-Id: <20090116112211.ea4231aa.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <496FE791.9030208@cn.fujitsu.com> References: <20090115192120.9956911b.kamezawa.hiroyu@jp.fujitsu.com> <20090115192943.7c1df53a.kamezawa.hiroyu@jp.fujitsu.com> <496FE30C.1090300@cn.fujitsu.com> <20090116103810.5ef55cc3.kamezawa.hiroyu@jp.fujitsu.com> <496FE791.9030208@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Li Zefan Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "menage@google.com" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" List-ID: On Fri, 16 Jan 2009 09:49:05 +0800 Li Zefan wrote: > KAMEZAWA Hiroyuki wrote: > > On Fri, 16 Jan 2009 09:29:48 +0800 > > Li Zefan wrote: > > > >>> /* > >>> - * Dance down the hierarchy if needed to reclaim memory. We remember the > >>> - * last child we reclaimed from, so that we don't end up penalizing > >>> - * one child extensively based on its position in the children list. > >>> + * Visit the first child (need not be the first child as per the ordering > >>> + * of the cgroup list, since we track last_scanned_child) of @mem and use > >>> + * that to reclaim free pages from. > >>> + */ > >>> +static struct mem_cgroup * > >>> +mem_cgroup_select_victim(struct mem_cgroup *root_mem) > >>> +{ > >>> + struct mem_cgroup *ret = NULL; > >>> + struct cgroup_subsys_state *css; > >>> + int nextid, found; > >>> + > >>> + if (!root_mem->use_hierarchy) { > >>> + spin_lock(&root_mem->reclaim_param_lock); > >>> + root_mem->scan_age++; > >>> + spin_unlock(&root_mem->reclaim_param_lock); > >>> + css_get(&root_mem->css); > >>> + ret = root_mem; > >>> + } > >>> + > >>> + while (!ret) { > >>> + rcu_read_lock(); > >>> + nextid = root_mem->last_scanned_child + 1; > >>> + css = css_get_next(&mem_cgroup_subsys, nextid, &root_mem->css, > >>> + &found); > >>> + if (css && css_is_populated(css) && css_tryget(css)) > >> I don't see why you need to check css_is_populated(css) ? > >> > > > > Main reason is for sanity. I don't like to hold css->refcnt of not populated css. > > I think this is a rare case. It's just a very short period when a cgroup is > being created but not yet fully created. > > > Second reason is for avoinding unnecessary calls to try_to_free_pages(), > > it's heavy. I should also add mem->res.usage == 0 case for skipping but not yet. > > > > And if mem->res.usage == 0 is checked, css_is_popuated() is just redundant. > Hmm ? Can I check mem->res.usage before css_tryget() ? -Kame > > THanks, > > -Kame > > > >>> + ret = container_of(css, struct mem_cgroup, css); > >>> + > >>> + rcu_read_unlock(); > >>> + /* Updates scanning parameter */ > >>> + spin_lock(&root_mem->reclaim_param_lock); > >>> + if (!css) { > >>> + /* this means start scan from ID:1 */ > >>> + root_mem->last_scanned_child = 0; > >>> + root_mem->scan_age++; > >>> + } else > >>> + root_mem->last_scanned_child = found; > >>> + spin_unlock(&root_mem->reclaim_param_lock); > >>> + } > >>> + > >>> + return ret; > >>> +} > >>> + > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org