From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: balbir@linux.vnet.ibm.com,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC] [PATCH] memcg: fix infinite loop
Date: Thu, 15 Jan 2009 16:35:59 +0900 [thread overview]
Message-ID: <20090115163559.ea5715c4.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <496EE683.8090101@cn.fujitsu.com>
On Thu, 15 Jan 2009 15:32:19 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > try_to_free_page() returns positive value if try_to_free_page() reclaims at
> > least 1 pages. It itself doesn't seem to be buggy.
> >
> > What buggy is resize_limit's retry-out check code, I think.
> >
> > How about following ?
>
> Not sure.
>
> I didn't look into the reclaim code, so I'd rather let you and Balbir decide if
> this is a bug and (if yes) how to fix it.
>
Hmm, I personally think this is not a bug. But *UNEXPECTED* behavior change, yes,
it's called regression.
To be honest, I never like retry-by-count because there is no trustable logic.
Thank you for reporting anyway. I'll consider some workaround.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-15 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 6:07 Li Zefan
2009-01-15 6:15 ` Balbir Singh
2009-01-15 6:31 ` KAMEZAWA Hiroyuki
2009-01-15 7:14 ` Li Zefan
2009-01-15 7:21 ` KAMEZAWA Hiroyuki
2009-01-15 7:26 ` Balbir Singh
2009-01-15 7:32 ` Li Zefan
2009-01-15 7:35 ` KAMEZAWA Hiroyuki [this message]
2009-01-15 6:16 ` Daisuke Nishimura
2009-01-15 6:27 ` Li Zefan
2009-01-19 8:49 ` KAMEZAWA Hiroyuki
2009-01-19 9:57 ` Balbir Singh
2009-01-19 10:07 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115163559.ea5715c4.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox