From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
yinghan@google.com, mikew@google.com, hugh@veritas.com
Subject: Re: mmotm 2009-01-12-16-53 uploaded
Date: Tue, 13 Jan 2009 18:13:17 +0900 [thread overview]
Message-ID: <20090113181317.48e910af.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <200901130053.n0D0rhev023334@imap1.linux-foundation.org>
On Mon, 12 Jan 2009 16:53:43 -0800
akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-01-12-16-53 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://git.zen-sources.org/zen/mmotm.git
>
After rtc compile fix, the kernel boots.
But with CONFIG_DEBUG_VM, I saw BUG_ON() at
fork() -> ...
-> copy_page_range() ...
-> copy_one_pte()
->page_dup_rmap()
-> __page_check_anon_rmap().
BUG_ON(page->index != linear_page_index(vma, address));
fires. (from above, the page is ANON.)
It seems page->index == 0x7FFFFFFE here and the page seems to be
the highest address of stack.
This is caused by
fs-execc-fix-value-of-vma-vm_pgoff-for-the-stack-vma-of-32-bit-processes.patch
This is a fix.
==
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
pgoff is *not* vma->vm_start >> PAGE_SHIFT.
And no adjustment is necessary (when it maps the same start
before/after adjust vma.)
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
Index: mmotm-2.6.29-Jan12/fs/exec.c
===================================================================
--- mmotm-2.6.29-Jan12.orig/fs/exec.c
+++ mmotm-2.6.29-Jan12/fs/exec.c
@@ -509,7 +509,7 @@ static int shift_arg_pages(struct vm_are
unsigned long length = old_end - old_start;
unsigned long new_start = old_start - shift;
unsigned long new_end = old_end - shift;
- unsigned long new_pgoff = new_start >> PAGE_SHIFT;
+ unsigned long new_pgoff = vma->vm_pgoff;
struct mmu_gather *tlb;
BUG_ON(new_start > new_end);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2009-01-13 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901130053.n0D0rhev023334@imap1.linux-foundation.org>
2009-01-13 9:13 ` KAMEZAWA Hiroyuki [this message]
2009-01-13 17:05 ` Mike Waychison
2009-01-14 7:22 ` [RFC][PATCH] don't show pgoff of vma if vma is pure ANON (was Re: mmotm 2009-01-12-16-53 uploaded) KAMEZAWA Hiroyuki
2009-01-14 14:08 ` Hugh Dickins
2009-01-15 2:43 ` KAMEZAWA Hiroyuki
2009-04-02 20:18 ` Andrew Morton
2009-04-03 0:27 ` KAMEZAWA Hiroyuki
2009-04-03 1:25 ` [PATCH] proc pid maps dont show pgoff of pure anon vmas style fix (WasRe: " KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113181317.48e910af.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mikew@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox