From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 413A36B0044 for ; Thu, 8 Jan 2009 23:25:09 -0500 (EST) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n094P64a004527 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 9 Jan 2009 13:25:06 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id BA8BC45DD74 for ; Fri, 9 Jan 2009 13:25:07 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 847B945DD72 for ; Fri, 9 Jan 2009 13:25:07 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id F04BD1DB803F for ; Fri, 9 Jan 2009 13:25:05 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 9DF311DB803A for ; Fri, 9 Jan 2009 13:25:05 +0900 (JST) Date: Fri, 9 Jan 2009 13:24:04 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/4] cgroup: support per cgroup subsys state ID (CSS ID) Message-Id: <20090109132404.6ece68e6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <4966CB89.1020403@cn.fujitsu.com> References: <20090108182556.621e3ee6.kamezawa.hiroyu@jp.fujitsu.com> <20090108182817.2c393351.kamezawa.hiroyu@jp.fujitsu.com> <4966CB89.1020403@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Li Zefan Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , "menage@google.com" List-ID: On Fri, 09 Jan 2009 11:59:05 +0800 Li Zefan wrote: > > static struct inode *cgroup_new_inode(mode_t mode, struct super_block *sb) > > { > > struct inode *inode = new_inode(sb); > > @@ -2335,6 +2339,7 @@ static void init_cgroup_css(struct cgrou > > css->cgroup = cgrp; > > atomic_set(&css->refcnt, 1); > > css->flags = 0; > > + css->id = NULL; > > if (cgrp == dummytop) > > set_bit(CSS_ROOT, &css->flags); > > BUG_ON(cgrp->subsys[ss->subsys_id]); > > @@ -2410,6 +2415,10 @@ static long cgroup_create(struct cgroup > > goto err_destroy; > > } > > init_cgroup_css(css, ss, cgrp); > > + if (ss->use_id) > > + if (alloc_css_id(ss, parent, cgrp)) > > + goto err_destroy; > > + /* At error, ->destroy() callback has to free assigned ID. */ > > A bug here: > > if alloc_css_id(ss, parent, cgrp) failed, then ss->destroy() called free_css_id(), > then panic. > > maybe check if (css->id == NULL) in free_css_id() ? > Oh, thanks. it will be necessary. I'll fix it. But..Hmm...maybe it's useful to add fault injection feature to debug cgroup for this kind of loop operation. -Kame > > } > > > > cgroup_lock_hierarchy(root); > > @@ -2699,6 +2708,8 @@ int __init cgroup_init(void) > > struct cgroup_subsys *ss = subsys[i]; > > if (!ss->early_init) > > cgroup_init_subsys(ss); > > + if (ss->use_id) > > + cgroup_subsys_init_idr(ss); > > } > > > > /* Add init_css_set to the hash table */ > > @@ -3231,3 +3242,260 @@ static int __init cgroup_disable(char *s > > return 1; > > } > > __setup("cgroup_disable=", cgroup_disable); > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org