From: Johannes Weiner <hannes@cmpxchg.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] failslab for SLUB
Date: Tue, 23 Dec 2008 16:22:23 +0100 [thread overview]
Message-ID: <20081223152223.GA3436@cmpxchg.org> (raw)
In-Reply-To: <1230043466.11073.0.camel@penberg-laptop>
On Tue, Dec 23, 2008 at 04:44:26PM +0200, Pekka Enberg wrote:
> Hi Hannes,
>
> On Tue, 2008-12-23 at 15:43 +0100, Johannes Weiner wrote:
> > > static inline void *____cache_alloc(struct kmem_cache *cachep,
> > gfp_t flags)
> > > {
> > > void *objp;
> > > @@ -3381,7 +3316,7 @@ __cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid,
> > > unsigned long save_flags;
> > > void *ptr;
> > >
> > > - if (should_failslab(cachep, flags))
> > > + if (slab_should_failslab(cachep, flags))
> >
> > should_failslab()?
>
> No, look at what slab_should_failslab() does. We need to exclude
> cache_cache in SLAB but not in SLUB.
Ah, crap. I missed that small '+' and thought it had been dropped.
Sorry, Pekka.
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-12-23 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 10:37 Akinobu Mita
2008-12-23 13:00 ` Pekka J Enberg
2008-12-23 13:29 ` Akinobu Mita
2008-12-23 14:43 ` Johannes Weiner
2008-12-23 14:44 ` Pekka Enberg
2008-12-23 15:22 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081223152223.GA3436@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox