From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Hugh Dickins <hugh@veritas.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [bug][mmtom] memcg: MEM_CGROUP_ZSTAT underflow
Date: Fri, 19 Dec 2008 18:40:17 +0900 [thread overview]
Message-ID: <20081219184017.7da8748e.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20081219182929.428380df.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, 19 Dec 2008 18:29:29 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> + /*
> + * Don't clear pc->mem_cgroup because del_from_lru() will see this.
> + * The fully unchaged page is assumed to be freed after us, so it's
> + * safe. When this page is reused before free, we have to be careful.
> + * (In SwapCache case...it can happen.)
> + */
>
Maybe this is better.
==
/*
* Don't clear pc->mem_cgroup because del_from_lru() may see this.
* If this page is fully unchaged, it's assumed to be freed soon,or it
* is isolated from LRU. When this page is reused before free
* (and on LRU), we have to be careful.
* (In SwapCache case...it can happen.)
*/
==
Hmm.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-19 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 8:29 Daisuke Nishimura
2008-12-19 9:29 ` KAMEZAWA Hiroyuki
2008-12-19 9:40 ` KAMEZAWA Hiroyuki [this message]
2008-12-19 17:08 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219184017.7da8748e.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox