From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id CF5A36B0074 for ; Tue, 16 Dec 2008 02:05:15 -0500 (EST) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id mBG76iQh022510 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 16 Dec 2008 16:06:45 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 9CA3A2AEA82 for ; Tue, 16 Dec 2008 16:06:44 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 775021EF082 for ; Tue, 16 Dec 2008 16:06:44 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 5D0EB1DB8041 for ; Tue, 16 Dec 2008 16:06:44 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 137CF1DB8038 for ; Tue, 16 Dec 2008 16:06:44 +0900 (JST) From: KOSAKI Motohiro Subject: [PATCH for 2.6.28] mm: Don't touch uninitialized variable in do_pages_stat_array() Message-Id: <20081216160303.DBA8.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 16 Dec 2008 16:06:43 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Brice Goglin , Christoph Lameter , KAMEZAWA Hiroyuki , Nick Piggin , Hugh Dickins , LKML , linux-mm , Andrew Morton , Linus Torvalds Cc: kosaki.motohiro@jp.fujitsu.com List-ID: 80bba1290ab5122c60cdb73332b26d288dc8aedd remove one necessary variable initialization. Then, following warning happend. CC mm/migrate.o mm/migrate.c: In function 'sys_move_pages': mm/migrate.c:1001: warning: 'err' may be used uninitialized in this function More unfortunately, if find_vma() failed, kernel read uninitialized memory. Signed-off-by: KOSAKI Motohiro CC: Brice Goglin Cc: Christoph Lameter Cc: KAMEZAWA Hiroyuki Cc: Nick Piggin Cc: Hugh Dickins --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/mm/migrate.c =================================================================== --- a/mm/migrate.c +++ b/mm/migrate.c @@ -998,7 +998,7 @@ static void do_pages_stat_array(struct m unsigned long addr = (unsigned long)(*pages); struct vm_area_struct *vma; struct page *page; - int err; + int err = -EFAULT; vma = find_vma(mm, addr); if (!vma) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org