From: "Hans J. Koch" <hjk@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Edward Estabrook <edward.estabrook.lkml@gmail.com>,
"Hans J. Koch" <hjk@linutronix.de>,
edward_estabrook@agilent.com, linux-kernel@vger.kernel.org,
gregkh@suse.de, edward.estabrook@gmail.com,
hugh <hugh@veritas.com>, linux-mm <linux-mm@kvack.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] Userspace I/O (UIO): Add support for userspace DMA
Date: Sat, 13 Dec 2008 01:29:35 +0100 [thread overview]
Message-ID: <20081213002934.GB3084@local> (raw)
In-Reply-To: <1229102712.13566.14.camel@twins>
On Fri, Dec 12, 2008 at 06:25:12PM +0100, Peter Zijlstra wrote:
> On Fri, 2008-12-05 at 16:32 -0800, Edward Estabrook wrote:
> > > Well, UIO already rapes the mmap interface by using the "offset" parameter to
> > > pass in the number of the mapping.
> >
> > Exactly.
>
> Had I known about it then, I'd NAK'd it, but I guess now that its
> already merged changing it will be hard :/
It was in -mm for half a year before it went to mainline in 2.6.23, the
documentation being present all the time. It was discussed intensively
on lkml, and several core kernel developers reviewed it. The special use
of the mmap() offset parameter was never even mentioned by anybody. I
remember that so well because I actually expected critizism, but everybody
was fine with it. And to be honest, even though it's unusual, I still find
it a good solution.
Thanks,
Hans
next prev parent reply other threads:[~2008-12-13 0:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <43FC624C55D8C746A914570B66D642610367F29B@cos-us-mb03.cos.agilent.com>
2008-12-04 8:39 ` Peter Zijlstra
2008-12-04 10:27 ` Hugh Dickins
2008-12-23 21:32 ` Max Krasnyansky
2008-12-04 18:08 ` Hans J. Koch
2008-12-05 7:10 ` Peter Zijlstra
2008-12-05 9:44 ` Hans J. Koch
2008-12-06 0:32 ` Edward Estabrook
2008-12-12 17:25 ` Peter Zijlstra
2008-12-13 0:29 ` Hans J. Koch [this message]
2009-12-12 0:02 ` Earl Chew
2009-12-14 19:23 ` Hans J. Koch
2009-12-15 13:34 ` Earl Chew
2009-12-15 17:47 ` Earl Chew
2009-12-15 21:33 ` Hans J. Koch
2009-12-15 21:00 ` Hans J. Koch
2009-12-15 21:47 ` Earl Chew
2009-12-15 22:28 ` Hans J. Koch
2009-12-16 0:20 ` Earl Chew
2009-12-16 1:23 ` Hans J. Koch
2009-12-16 1:45 ` Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213002934.GB3084@local \
--to=hjk@linutronix.de \
--cc=edward.estabrook.lkml@gmail.com \
--cc=edward.estabrook@gmail.com \
--cc=edward_estabrook@agilent.com \
--cc=gregkh@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox