Re: [RFC][PATCH] memcg: show real limit under hierarchy

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Thu, 11 Dec 2008 19:30:46 +0530
"Balbir Singh" <balbir@linux.vnet.ibm.com> wrote:

> On Thu, Dec 11, 2008 at 8:54 AM, KOSAKI Motohiro
> <kosaki.motohiro@jp.fujitsu.com> wrote:
> >> I wonder other people who debugs memcg's hierarchy may use similar patches.
> >> this is my one.
> >> comments ?
> >> ==
> >> From:KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >>
> >> Show "real" limit of memcg.
> >> This helps my debugging and maybe useful for users.
> >>
> >> While testing hierarchy like this
> >>
> >>       mount -t cgroup none /cgroup -t memory
> >>       mkdir /cgroup/A
> >>       set use_hierarchy==1 to "A"
> >>       mkdir /cgroup/A/01
> >>       mkdir /cgroup/A/01/02
> >>       mkdir /cgroup/A/01/03
> >>       mkdir /cgroup/A/01/03/04
> >>       mkdir /cgroup/A/08
> >>       mkdir /cgroup/A/08/01
> >>       ....
> >> and set each own limit to them, "real" limit of each memcg is unclear.
> >> This patch shows real limit by checking all ancestors in memory.stat.
> >>
> >> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >
> > Great!
> >
> > I hoped to use this patch at hierarchy inactive_ratio debugging ;)
> 
> I like this very much too
> 
> I would prefer to use
> 
> min_limit = min(tmp, min_limit); and similarly for min_memsw_limit
> 
> Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
> 
Thanks, I'll upadte this and forward to Andrew.

-Kame


> Balbir
>