linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nick Andrew <nick@nick-andrew.net>
To: Nick Piggin <npiggin@suse.de>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	Hugh Dickins <hugh@veritas.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Fix incorrect use of loose in migrate.c
Date: Sun, 7 Dec 2008 00:55:36 +1100	[thread overview]
Message-ID: <20081206135536.GH5957@mail.local.tull.net> (raw)
In-Reply-To: <20081206121227.GA6292@wotan.suse.de>

On Sat, Dec 06, 2008 at 01:12:27PM +0100, Nick Piggin wrote:
> >  	/*
> >  	 * A dirty page may imply that the underlying filesystem has
> >  	 * the page on some queue. So the page must be clean for
> > -	 * migration. Writeout may mean we loose the lock and the
> > +	 * migration. Writeout may mean we lose the lock and the
> >  	 * page state is no longer what we checked for earlier.
> >  	 * At this point we know that the migration attempt cannot
> >  	 * be successful.
> 
> I don't know... presumably we haven't just gone and lost the little
> bugger. I mean, we were holding it one minute, then... gone?  Do we
> have Alzheimer's? Unlikely. I think we loosed it.

Loosen?

Nick.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-12-06 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05  3:08 Nick Andrew
2008-12-06 12:12 ` Nick Piggin
2008-12-06 13:55   ` Nick Andrew [this message]
2008-12-08  3:46     ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081206135536.GH5957@mail.local.tull.net \
    --to=nick@nick-andrew.net \
    --cc=cl@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox