linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Pavel Emelyanov <xemul@openvz.org>,
	Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <menage@google.com>,
	nishimura@mxp.nes.nec.co.jp
Subject: [RFC][PATCH -mmotm 1/4] memcg: don't trigger oom at page migration
Date: Fri, 5 Dec 2008 21:23:04 +0900	[thread overview]
Message-ID: <20081205212304.f7018ea1.nishimura@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20081205212208.31d904e0.nishimura@mxp.nes.nec.co.jp>

I think triggering OOM at mem_cgroup_prepare_migration would be just a bit
overkill.
Returning -ENOMEM would be enough for mem_cgroup_prepare_migration.
The caller would handle the case anyway.

Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
---
 mm/memcontrol.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 4dbce1d..50ee1be 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1330,7 +1330,7 @@ int mem_cgroup_prepare_migration(struct page *page, struct mem_cgroup **ptr)
 	unlock_page_cgroup(pc);
 
 	if (mem) {
-		ret = mem_cgroup_try_charge(NULL, GFP_KERNEL, &mem);
+		ret = __mem_cgroup_try_charge(NULL, GFP_KERNEL, &mem, false);
 		css_put(&mem->css);
 	}
 	*ptr = mem;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-12-05 12:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 12:22 [RFC][PATCH -mmotm 0/4] patches for memory cgroup (20081205) Daisuke Nishimura
2008-12-05 12:23 ` Daisuke Nishimura [this message]
2008-12-05 13:22   ` [RFC][PATCH -mmotm 1/4] memcg: don't trigger oom at page migration KAMEZAWA Hiroyuki
2008-12-05 13:39   ` Balbir Singh
2008-12-06  2:47     ` Daisuke Nishimura
2008-12-06  8:18       ` Balbir Singh
2008-12-05 12:24 ` [RFC][PATCH -mmotm 2/4] memcg: remove mem_cgroup_try_charge Daisuke Nishimura
2008-12-05 13:24   ` KAMEZAWA Hiroyuki
2008-12-05 12:24 ` [RFC][PATCH -mmotm 3/4] memcg: avoid dead lock caused by race between oom and cpuset_attach Daisuke Nishimura
2008-12-05 13:27   ` [RFC][PATCH -mmotm 3/4] memcg: avoid dead lock caused by racebetween " KAMEZAWA Hiroyuki
2008-12-06  3:35     ` Daisuke Nishimura
2008-12-05 13:52   ` [RFC][PATCH -mmotm 3/4] memcg: avoid dead lock caused by race between " Balbir Singh
2008-12-05 12:25 ` [RFC][PATCH -mmotm 4/4] memcg: change try_to_free_pages to hierarchical_reclaim Daisuke Nishimura
2008-12-05 13:30   ` [RFC][PATCH -mmotm 4/4] memcg: change try_to_free_pages tohierarchical_reclaim KAMEZAWA Hiroyuki
2008-12-05 13:54   ` [RFC][PATCH -mmotm 4/4] memcg: change try_to_free_pages to hierarchical_reclaim Balbir Singh
2008-12-06  3:42 ` [RFC][PATCH -mmotm 0/4] patches for memory cgroup (20081205) Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081205212304.f7018ea1.nishimura@mxp.nes.nec.co.jp \
    --to=nishimura@mxp.nes.nec.co.jp \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox