From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mt1.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id mB53Pqxo028651 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 5 Dec 2008 12:25:52 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 3F39445DE4F for ; Fri, 5 Dec 2008 12:25:52 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 1D61D45DD7A for ; Fri, 5 Dec 2008 12:25:52 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 050CD1DB803A for ; Fri, 5 Dec 2008 12:25:52 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id AC2AE1DB803E for ; Fri, 5 Dec 2008 12:25:48 +0900 (JST) Date: Fri, 5 Dec 2008 12:24:58 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [memcg BUG ?] failed to boot on IA64 with CONFIG_DISCONTIGMEM=y Message-Id: <20081205122458.a37ae8e0.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20081205122024.3fcc1d0e.kamezawa.hiroyu@jp.fujitsu.com> References: <49389B69.9010902@cn.fujitsu.com> <20081205122024.3fcc1d0e.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Li Zefan , Balbir Singh , LKML , "linux-mm@kvack.org" , Andrew Morton List-ID: On Fri, 5 Dec 2008 12:20:24 +0900 KAMEZAWA Hiroyuki wrote: > On Fri, 05 Dec 2008 11:09:29 +0800 > Li Zefan wrote: > > > Kernel version: 2.6.28-rc7 > > Arch: IA64 > > Memory model: DISCONTIGMEM > > > > ELILO boot: Uncompressing Linux... done > > Loading file initrd-2.6.28-rc7-lizf.img...done > > (frozen) > > > > > > Booted successfully with cgroup_disable=memory, here is the dmesg: > > > > thx, will dig into...Maybe you're the first person using DISCONTIGMEM with > empty_node after page_cgroup-alloc-at-boot. > > How about this ? Ahhh..sorry. this one please. == From: kamezawa.hiroyu@jp.fujitsu.com page_cgroup should ignore empty-nodes. Signed-off-by: KAMEZAWA Hiroyuki --- mm/page_cgroup.c | 3 +++ 1 file changed, 3 insertions(+) Index: mmotm-2.6.28-Dec03/mm/page_cgroup.c =================================================================== --- mmotm-2.6.28-Dec03.orig/mm/page_cgroup.c +++ mmotm-2.6.28-Dec03/mm/page_cgroup.c @@ -51,6 +51,9 @@ static int __init alloc_node_page_cgroup start_pfn = NODE_DATA(nid)->node_start_pfn; nr_pages = NODE_DATA(nid)->node_spanned_pages; + if (!nr_pages) + return 0; + table_size = sizeof(struct page_cgroup) * nr_pages; base = __alloc_bootmem_node_nopanic(NODE_DATA(nid), -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org