linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix incorrect use of loose in migrate.c
@ 2008-12-05  3:08 Nick Andrew
  2008-12-06 12:12 ` Nick Piggin
  0 siblings, 1 reply; 4+ messages in thread
From: Nick Andrew @ 2008-12-05  3:08 UTC (permalink / raw)
  To: Christoph Lameter, Hugh Dickins, KAMEZAWA Hiroyuki, Nick Piggin,
	Rik van Riel, linux-kernel, linux-mm
  Cc: Nick Andrew

Fix incorrect use of loose in migrate.c

It should be 'lose', not 'loose'.

Signed-off-by: Nick Andrew <nick@nick-andrew.net>
---

 mm/migrate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/mm/migrate.c b/mm/migrate.c
index 1e0d6b2..7605b2b 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -514,7 +514,7 @@ static int writeout(struct address_space *mapping, struct page *page)
 	/*
 	 * A dirty page may imply that the underlying filesystem has
 	 * the page on some queue. So the page must be clean for
-	 * migration. Writeout may mean we loose the lock and the
+	 * migration. Writeout may mean we lose the lock and the
 	 * page state is no longer what we checked for earlier.
 	 * At this point we know that the migration attempt cannot
 	 * be successful.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix incorrect use of loose in migrate.c
  2008-12-05  3:08 [PATCH] Fix incorrect use of loose in migrate.c Nick Andrew
@ 2008-12-06 12:12 ` Nick Piggin
  2008-12-06 13:55   ` Nick Andrew
  0 siblings, 1 reply; 4+ messages in thread
From: Nick Piggin @ 2008-12-06 12:12 UTC (permalink / raw)
  To: Nick Andrew
  Cc: Christoph Lameter, Hugh Dickins, KAMEZAWA Hiroyuki, Rik van Riel,
	linux-kernel, linux-mm

On Fri, Dec 05, 2008 at 02:08:07PM +1100, Nick Andrew wrote:
> Fix incorrect use of loose in migrate.c
> 
> It should be 'lose', not 'loose'.
> 
> Signed-off-by: Nick Andrew <nick@nick-andrew.net>
> ---
> 
>  mm/migrate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 1e0d6b2..7605b2b 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -514,7 +514,7 @@ static int writeout(struct address_space *mapping, struct page *page)
>  	/*
>  	 * A dirty page may imply that the underlying filesystem has
>  	 * the page on some queue. So the page must be clean for
> -	 * migration. Writeout may mean we loose the lock and the
> +	 * migration. Writeout may mean we lose the lock and the
>  	 * page state is no longer what we checked for earlier.
>  	 * At this point we know that the migration attempt cannot
>  	 * be successful.

I don't know... presumably we haven't just gone and lost the little
bugger. I mean, we were holding it one minute, then... gone?  Do we
have Alzheimer's? Unlikely. I think we loosed it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix incorrect use of loose in migrate.c
  2008-12-06 12:12 ` Nick Piggin
@ 2008-12-06 13:55   ` Nick Andrew
  2008-12-08  3:46     ` Valdis.Kletnieks
  0 siblings, 1 reply; 4+ messages in thread
From: Nick Andrew @ 2008-12-06 13:55 UTC (permalink / raw)
  To: Nick Piggin
  Cc: Christoph Lameter, Hugh Dickins, KAMEZAWA Hiroyuki, Rik van Riel,
	linux-kernel, linux-mm

On Sat, Dec 06, 2008 at 01:12:27PM +0100, Nick Piggin wrote:
> >  	/*
> >  	 * A dirty page may imply that the underlying filesystem has
> >  	 * the page on some queue. So the page must be clean for
> > -	 * migration. Writeout may mean we loose the lock and the
> > +	 * migration. Writeout may mean we lose the lock and the
> >  	 * page state is no longer what we checked for earlier.
> >  	 * At this point we know that the migration attempt cannot
> >  	 * be successful.
> 
> I don't know... presumably we haven't just gone and lost the little
> bugger. I mean, we were holding it one minute, then... gone?  Do we
> have Alzheimer's? Unlikely. I think we loosed it.

Loosen?

Nick.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix incorrect use of loose in migrate.c
  2008-12-06 13:55   ` Nick Andrew
@ 2008-12-08  3:46     ` Valdis.Kletnieks
  0 siblings, 0 replies; 4+ messages in thread
From: Valdis.Kletnieks @ 2008-12-08  3:46 UTC (permalink / raw)
  To: Nick Andrew
  Cc: Nick Piggin, Christoph Lameter, Hugh Dickins, KAMEZAWA Hiroyuki,
	Rik van Riel, linux-kernel, linux-mm

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On Sun, 07 Dec 2008 00:55:36 +1100, Nick Andrew said:
> On Sat, Dec 06, 2008 at 01:12:27PM +0100, Nick Piggin wrote:

> > I don't know... presumably we haven't just gone and lost the little
> > bugger. I mean, we were holding it one minute, then... gone?  Do we
> > have Alzheimer's? Unlikely. I think we loosed it.
> 
> Loosen?

"Cry Cheeble, and loose the hamsters of war!"

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-12-08  3:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-05  3:08 [PATCH] Fix incorrect use of loose in migrate.c Nick Andrew
2008-12-06 12:12 ` Nick Piggin
2008-12-06 13:55   ` Nick Andrew
2008-12-08  3:46     ` Valdis.Kletnieks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox