From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
riel@redhat.com, hugh@veritas.com
Subject: Re: [PATCH] - support inheritance of mlocks across fork/exec V2
Date: Thu, 4 Dec 2008 10:57:38 +0900 (JST) [thread overview]
Message-ID: <20081204105527.1D5F.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <1228331069.6693.73.camel@lts-notebook>
> @@ -600,9 +603,15 @@ asmlinkage long sys_mlockall(int flags)
> unsigned long lock_limit;
> int ret = -EINVAL;
>
> - if (!flags || (flags & ~(MCL_CURRENT | MCL_FUTURE)))
> + if (!(flags & (MCL_CURRENT | MCL_FUTURE)))
> goto out;
>
> + if (flags & ~(MCL_CURRENT | MCL_FUTURE | MCL_INHERIT | MCL_RECURSIVE))
> + goto out; /* undefined flag bits */
> +
> + if ((flags & (MCL_INHERIT | MCL_RECURSIVE)) == MCL_RECURSIVE)
> + goto out; /* 'RECURSIVE undefined without 'INHERIT */
> +
> ret = -EPERM;
> if (!can_do_mlock())
> goto out;
looks good to me.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-04 1:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 21:21 [PATCH/RFC] - support inheritance of mlocks across fork/exec Lee Schermerhorn
2008-11-25 4:05 ` KOSAKI Motohiro
2008-11-25 16:21 ` Rik van Riel
2008-11-25 23:26 ` Andrew Morton
2008-12-03 19:04 ` [PATCH] - support inheritance of mlocks across fork/exec V2 Lee Schermerhorn
2008-12-04 1:57 ` KOSAKI Motohiro [this message]
2008-12-07 6:07 ` Andrew Morton
2008-12-08 15:01 ` Lee Schermerhorn
2008-12-08 21:05 ` Lee Schermerhorn
2008-12-08 21:33 ` Matt Mackall
2008-12-09 19:40 ` Lee Schermerhorn
2008-12-09 20:41 ` Matt Mackall
2009-06-05 4:39 ` Jon Masters
2009-06-05 4:49 ` KOSAKI Motohiro
2009-06-05 5:12 ` Jon Masters
2008-11-26 8:37 ` [PATCH/RFC] - support inheritance of mlocks across fork/exec KOSAKI Motohiro
2008-11-29 22:38 ` Lee Schermerhorn
2008-11-30 5:21 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204105527.1D5F.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox