linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH  9/21] make-get_scan_ratio-to-memcg-safe.patch
Date: Wed, 3 Dec 2008 13:57:12 +0900	[thread overview]
Message-ID: <20081203135712.4c89b83d.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20081203134718.6b60986f.kamezawa.hiroyu@jp.fujitsu.com>

Currently, get_scan_ratio() always calculate the balancing value for global reclaim and
memcg reclaim doesn't use it.
Therefore it doesn't have scan_global_lru() condition.

However, we plan to expand get_scan_ratio() to be usable for memcg too, latter.
Then, The dependency code of global reclaim in the get_scan_ratio() insert into
scan_global_lru() condision explictly.


this patch doesn't have any functional change.

Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Index: mmotm-2.6.28-Dec02/mm/vmscan.c
===================================================================
--- mmotm-2.6.28-Dec02.orig/mm/vmscan.c
+++ mmotm-2.6.28-Dec02/mm/vmscan.c
@@ -1430,13 +1430,16 @@ static void get_scan_ratio(struct zone *
 		zone_nr_pages(zone, sc, LRU_INACTIVE_ANON);
 	file  = zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) +
 		zone_nr_pages(zone, sc, LRU_INACTIVE_FILE);
-	free  = zone_page_state(zone, NR_FREE_PAGES);
 
-	/* If we have very few page cache pages, force-scan anon pages. */
-	if (unlikely(file + free <= zone->pages_high)) {
-		percent[0] = 100;
-		percent[1] = 0;
-		return;
+	if (scan_global_lru(sc)) {
+		free  = zone_page_state(zone, NR_FREE_PAGES);
+		/* If we have very few page cache pages,
+		   force-scan anon pages. */
+		if (unlikely(file + free <= zone->pages_high)) {
+			percent[0] = 100;
+			percent[1] = 0;
+			return;
+		}
 	}
 
 	/*

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-12-03  4:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03  4:47 [PATCH 0/21] memcg updates 2008/12/03 KAMEZAWA Hiroyuki
2008-12-03  4:48 ` [PATCH 1/21] memcg-revert-gfp-mask-fix.patch KAMEZAWA Hiroyuki
2008-12-03  4:50 ` [PATCH 2/21] memcg-check-group-leader-fix.patch KAMEZAWA Hiroyuki
2008-12-03  4:51 ` [PATCH 3/21] memcg-memoryswap-controller-fix-limit-check.patch KAMEZAWA Hiroyuki
2008-12-03  4:52 ` [PATCH 4/21] memcg-swapout-refcnt-fix.patch KAMEZAWA Hiroyuki
2008-12-03  4:53 ` [PATCH 5/21] memcg-hierarchy-avoid-unnecessary-reclaim.patch KAMEZAWA Hiroyuki
2008-12-03  4:54 ` [PATCH 6/21] inactive_anon_is_low-move-to-vmscan.patch KAMEZAWA Hiroyuki
2008-12-03  4:55 ` [PATCH 7/21] introduce-zone_reclaim-struct.patch KAMEZAWA Hiroyuki
2008-12-03  4:55 ` [PATCH 8/21] make-zone-nr_pages-helper-function.patch KAMEZAWA Hiroyuki
2008-12-03  4:57 ` KAMEZAWA Hiroyuki [this message]
2008-12-03  4:58 ` [PATCH 10/21] memcg-add-null-check-to-page_cgroup_zoneinfo.patch KAMEZAWA Hiroyuki
2008-12-03  5:00 ` [PATCH 11/21] memcg-make-inactive_anon_is_low.patch KAMEZAWA Hiroyuki
2008-12-03  5:01 ` [PATCH 12/21] memcg-make-mem_cgroup_zone_nr_pages.patch KAMEZAWA Hiroyuki
2008-12-03  5:02 ` [PATCH 13/21] memcg-make-zone_reclaim_stat.patch KAMEZAWA Hiroyuki
2008-12-03  5:04 ` [PATCH 14/21] memcg-remove-mem_cgroup_cal_reclaim.patch KAMEZAWA Hiroyuki
2008-12-03  5:05 ` [PATCH 15/21] memcg-show-reclaim-stat.patch KAMEZAWA Hiroyuki
2008-12-03  5:06 ` [PATCH 16/21] memcg-rename-scan-glonal-lru.patch KAMEZAWA Hiroyuki
2008-12-03  5:08 ` [PATCH 17/21] memcg_prev_priority_protect.patch KAMEZAWA Hiroyuki
2008-12-03  5:09 ` [PATCH 18/21] memcg-swappiness.patch KAMEZAWA Hiroyuki
2008-12-03  5:11 ` [Experimental][PATCH 19/21] memcg-fix-pre-destroy.patch KAMEZAWA Hiroyuki
2008-12-04  9:34   ` Daisuke Nishimura
2008-12-04  9:43     ` KAMEZAWA Hiroyuki
2008-12-04  9:49       ` KAMEZAWA Hiroyuki
2008-12-04 10:17       ` Daisuke Nishimura
2008-12-03  5:12 ` [Experimental][PATCH 20/21] cgroup_id.patch KAMEZAWA Hiroyuki
2008-12-03  5:14 ` [Experimental][PATCH 21/21] memcg-new-hierarchical-reclaim.patch KAMEZAWA Hiroyuki
2008-12-04 11:00   ` Daisuke Nishimura
2008-12-04 12:44     ` [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch KAMEZAWA Hiroyuki
2008-12-03  5:15 ` [PATCH 22/21] memcg-explain-details-and-test-document.patch KAMEZAWA Hiroyuki
2008-12-03  5:20 ` [PATCH 0/21] memcg updates 2008/12/03 KAMEZAWA Hiroyuki
2008-12-03  5:56 ` Andrew Morton
2008-12-03  6:17   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203135712.4c89b83d.kamezawa.hiroyu@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nishimura@mxp.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox