Re: [PATCH][V6]make get_user_pages interruptible

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> > more unfortunately, this patch break kernel compatibility.
> > To read /proc file invoke calling get_user_page().
> > however, "man 2 read" doesn't describe ERESTARTSYS.
> yeah, that seems to be right..
> >
> > IOW, this patch can break /proc reading user application.
> >
> > May I ask why fatal_signal_pending(tsk) is needed ?
> > at least, you need to cc to linux-api@vger.kernel.org IMHO.
> all the problems seems to be caused by the fatal_signal_pending(tsk),
> i can either make the change like
> if (fatal_signal_pending(tsk))
>    return i ? i : EINTR
> 
> or remove the check for fatal_signal_pending(tsk) which is mainly used in
> the case you mentioned above. Afterward, the intial point of the patch is to
> avoid proccess hanging in the mlock (for example) under memory
> pressure while it has SIGKILL pending. Now sounds to me the second option is
> better. any comments?

it seems both reasonable.
in my personal feeling, I like simple removing than EINTR.



> > Am I talking about pointless?
> thanks for comments. :-)

Could you please cc to me at posting v7.
maybe, I can ack.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>