From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Nick Piggin <npiggin@suse.de>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 2/2] fs: symlink write_begin allocation context fix
Date: Sat, 29 Nov 2008 15:35:22 +0900 (JST) [thread overview]
Message-ID: <20081129153455.8128.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20081128143737.GA15458@wotan.suse.de>
> On Thu, Nov 27, 2008 at 08:02:32PM +0900, KOSAKI Motohiro wrote:
> > > @@ -2820,8 +2825,7 @@ fail:
> > >
> > > int page_symlink(struct inode *inode, const char *symname, int len)
> > > {
> > > - return __page_symlink(inode, symname, len,
> > > - mapping_gfp_mask(inode->i_mapping));
> > > + return __page_symlink(inode, symname, len, 0);
> > > }
> >
> > your patch always pass 0 into __page_symlink().
> > therefore it doesn't change any behavior.
> >
> > right?
>
> How about this patch?
looks good to me.
very thanks.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-29 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 9:34 [patch 1/2] mm: pagecache allocation gfp fixes Nick Piggin
2008-11-27 9:35 ` [patch 2/2] fs: symlink write_begin allocation context fix Nick Piggin
2008-11-27 11:02 ` KOSAKI Motohiro
2008-11-27 11:14 ` Nick Piggin
2008-11-28 14:37 ` Nick Piggin
2008-11-29 6:35 ` KOSAKI Motohiro [this message]
2008-11-27 9:52 ` [patch 1/2] mm: pagecache allocation gfp fixes Pekka Enberg
2008-11-27 10:01 ` Nick Piggin
2008-11-27 10:18 ` Nick Piggin
2008-11-27 10:28 ` Pekka Enberg
2008-11-27 10:40 ` KOSAKI Motohiro
2008-11-27 18:14 ` Hugh Dickins
2008-11-28 12:04 ` Nick Piggin
2008-12-01 1:18 ` Hugh Dickins
2008-12-01 1:50 ` KAMEZAWA Hiroyuki
2008-12-01 7:39 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081129153455.8128.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox