From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
riel@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics.
Date: Thu, 27 Nov 2008 12:49:46 +0900 [thread overview]
Message-ID: <20081127124946.912541e2.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20081125155422.6ab07caf.akpm@linux-foundation.org>
On Tue, 25 Nov 2008 15:54:22 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
> > + if (scan_global_lru(sc))
>
> mutter. scan_global_lru() is a terrible function name. Anyone reading
> that code would expect that this function, umm, scans the global LRU.
>
> gcc has a nice convention wherein such functions have a name ending in
> "_p" (for "predicate"). Don't do this :)
>
Hmm, I'll prepare renaming patch.
scan_global_lru_p() ? or under_scanning_global_lru() ?
Thanks,
-Kame
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-27 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 3:22 KOSAKI Motohiro
2008-11-25 15:51 ` Rik van Riel
2008-11-25 23:54 ` Andrew Morton
2008-11-26 0:13 ` KOSAKI Motohiro
2008-11-26 0:16 ` Alan Cox
2008-11-26 0:19 ` KOSAKI Motohiro
2008-11-27 3:49 ` KAMEZAWA Hiroyuki [this message]
2008-11-27 3:59 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127124946.912541e2.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox