Re: [RFC v1][PATCH]page_fault retry with NOPAGE_RETRY

[Nick Piggin <npiggin@suse.de>]

On Tue, Nov 25, 2008 at 10:42:47AM -0800, Ying Han wrote:
> >> The patch flags current->flags to PF_FAULT_MAYRETRY as identify that
> >> the caller can tolerate the retry in the filemap_fault call patch.
> >>
> >> Benchmark is done by mmap in huge file and spaw 64 thread each
> >> faulting in pages in reverse order, the the result shows 8%
> >> porformance hit with the patch.
> >
> > I suspect we also want to see the cases where this change helps?
> i am working on more benchmark to show performance improvement.

Can't you share the actual improvement you see inside Google?

Google must be doing something funky with threads, because both
this patch and their new malloc allocator apparently were due to
mmap_sem contention problems, right?

That was before the kernel and glibc got together to fix the stupid
mmap_sem problem in malloc (shown up in that FreeBSD MySQL thread);
and before private futexes. I would be interested to know if Google
still has problems that require this patch...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>