linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: yinghan@google.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, menage@google.com,
	rientjes@google.com, rohitseth@google.com
Subject: Re: [PATCH][V4]Make get_user_pages interruptible
Date: Tue, 25 Nov 2008 15:43:54 -0800	[thread overview]
Message-ID: <20081125154354.001a6ae0.akpm@linux-foundation.org> (raw)
In-Reply-To: <1227605300.1566.17.camel@penberg-laptop>

On Tue, 25 Nov 2008 11:28:20 +0200
Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> ___You might want to add an explanation why we check both 'tsk' and
> 'current' in either in the patch description or as a comment, though. Or
> just add a link to the mailing list archives in the description or
> something.

As a code comment, I'd suggest.

> > Signed-off-by:	Paul Menage <menage@google.com>
> > Singed-off-by:	Ying Han <yinghan@google.com>
>   ^^^^^^
> 
> I'm sure you have a beautiful singing voice but from legal point of
> view, it's probably better to just sign it off. ;-)

That's my favorite typo.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2008-11-25 23:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 23:21 Ying Han
2008-11-25  9:28 ` Pekka Enberg
2008-11-25 23:43   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125154354.001a6ae0.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rientjes@google.com \
    --cc=rohitseth@google.com \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox