From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id mAP3MsuW000844 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 25 Nov 2008 12:22:54 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 472A045DD7D for ; Tue, 25 Nov 2008 12:22:54 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 259A445DD7C for ; Tue, 25 Nov 2008 12:22:54 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0EE521DB803A for ; Tue, 25 Nov 2008 12:22:54 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.249.87.107]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id B71CA1DB8037 for ; Tue, 25 Nov 2008 12:22:53 +0900 (JST) From: KOSAKI Motohiro Subject: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics. Message-Id: <20081125121842.26C5.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 25 Nov 2008 12:22:53 +0900 (JST) Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel , LKML , linux-mm , Andrew Morton Cc: kosaki.motohiro@jp.fujitsu.com List-ID: Hi this is a trivial bugfix. I think this is not serious bug. but if memcgroup reclaim change zone statics, global reclaim can confusion a bit. ================================================ memcg reclaim shouldn't change zone->recent_rotated statics. Signed-off-by: KOSAKI Motohiro CC: Rik van Riel --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/mm/vmscan.c =================================================================== --- a/mm/vmscan.c 2008-11-24 06:20:24.000000000 +0900 +++ b/mm/vmscan.c 2008-11-25 01:29:16.000000000 +0900 @@ -1254,7 +1254,8 @@ static void shrink_active_list(unsigned * This helps balance scan pressure between file and anonymous * pages in get_scan_ratio. */ - zone->recent_rotated[!!file] += pgmoved; + if (scan_global_lru(sc)) + zone->recent_rotated[!!file] += pgmoved; /* * Move the pages to the [file or anon] inactive list. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org