linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>, Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH -mm] vmscan: bail out of page reclaim after swap_cluster_max pages
Date: Sun, 16 Nov 2008 16:38:56 +0900 (JST)	[thread overview]
Message-ID: <20081116163316.F205.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20081113171208.6985638e@bree.surriel.com>

One more point.

> Sometimes the VM spends the first few priority rounds rotating back
> referenced pages and submitting IO.  Once we get to a lower priority,
> sometimes the VM ends up freeing way too many pages.
> 
> The fix is relatively simple: in shrink_zone() we can check how many
> pages we have already freed and break out of the loop.
> 
> However, in order to do this we do need to know how many pages we already
> freed, so move nr_reclaimed into scan_control.

IIRC, Balbir-san explained the implemetation of the memcgroup 
force cache dropping feature need non bail out at the past reclaim 
throttring discussion.

I am not sure about this still right or not (iirc, memcgroup implemetation
was largely changed).

Balbir-san, Could you comment to this patch?



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-11-16  7:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 22:12 Rik van Riel
2008-11-14  0:51 ` KOSAKI Motohiro
2008-11-14  3:27 ` Andrew Morton
2008-11-14 14:36   ` Rik van Riel
2008-11-14 17:18     ` Andrew Morton
2008-11-16  7:43       ` KOSAKI Motohiro
2008-11-16  7:54         ` Andrew Morton
2008-11-16  7:56           ` KOSAKI Motohiro
2008-11-16  8:02             ` Andrew Morton
2008-11-22 10:22           ` KOSAKI Motohiro
2008-11-22 16:57             ` Rik van Riel
2008-11-24 19:12               ` KOSAKI Motohiro
2008-11-24 19:18                 ` Rik van Riel
2008-11-16  7:38 ` KOSAKI Motohiro [this message]
2008-11-17  0:38   ` KAMEZAWA Hiroyuki
2008-11-17  3:43     ` Balbir Singh
2008-11-19 16:54 ` Mel Gorman
2008-11-21 11:59   ` Petr Tesarik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116163316.F205.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox