From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 14 Nov 2008 12:34:22 -0500 From: Christoph Hellwig Subject: Re: [PATCH 2.6.28?] don't unlink an active swapfile Message-ID: <20081114173422.GA22868@infradead.org> References: <20081018003117.GC26067@cordes.ca> <20081018051800.GO24654@1wt.eu> <20081018204948.GA22140@infradead.org> <20081018205647.GA29946@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andrew Morton , Willy Tarreau , Christoph Hellwig , Peter Cordes , Bodo Eggert <7eggert@gmx.de>, David Newall , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm List-ID: On Fri, Nov 14, 2008 at 02:37:22AM +0000, Hugh Dickins wrote: > Peter Cordes is sorry that he rm'ed his swapfiles while they were in use, > he then had no pathname to swapoff. It's a curious little oversight, but > not one worth a lot of hackery. Kudos to Willy Tarreau for turning this > around from a discussion of synthetic pathnames to how to prevent unlink. > Mimic immutable: prohibit unlinking an active swapfile in may_delete() > (and don't worry my little head over the tiny race window). Looks good (but I think I already said this before) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org