From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id mAD3crk5014833 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Thu, 13 Nov 2008 12:38:53 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0B8E745DD7D for ; Thu, 13 Nov 2008 12:38:53 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id B8A7D45DD7B for ; Thu, 13 Nov 2008 12:38:52 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 81573E0800C for ; Thu, 13 Nov 2008 12:38:52 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 2326A1DB8038 for ; Thu, 13 Nov 2008 12:38:52 +0900 (JST) Date: Thu, 13 Nov 2008 12:38:15 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/6] memcg: free all at rmdir Message-Id: <20081113123816.873477a1.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <491B9E8B.3080301@linux.vnet.ibm.com> References: <20081112122606.76051530.kamezawa.hiroyu@jp.fujitsu.com> <20081112122656.c6e56248.kamezawa.hiroyu@jp.fujitsu.com> <20081112160758.3dca0b22.akpm@linux-foundation.org> <20081113114908.42a6a8a7.kamezawa.hiroyu@jp.fujitsu.com> <491B9BB3.6010701@linux.vnet.ibm.com> <20081113122241.b77a0d14.kamezawa.hiroyu@jp.fujitsu.com> <491B9E8B.3080301@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: balbir@linux.vnet.ibm.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nishimura@mxp.nes.nec.co.jp, Paul Menage List-ID: On Thu, 13 Nov 2008 08:57:07 +0530 Balbir Singh wrote: > KAMEZAWA Hiroyuki wrote: > > On Thu, 13 Nov 2008 08:44:59 +0530 > > Balbir Singh wrote: > > > >> KAMEZAWA Hiroyuki wrote: > >>> On Wed, 12 Nov 2008 16:07:58 -0800 > >>> Andrew Morton wrote: > >>>> If we do this then we can make the above "keep" behaviour non-optional, > >>>> and the operator gets to choose whether or not to drop the caches > >>>> before doing the rmdir. > >>>> > >>>> Plus, we get a new per-memcg drop_caches capability. And it's a nicer > >>>> interface, and it doesn't have the obvious races which on_rmdir has, > >>>> etc. > >>>> > >>>> hm? > >>>> > >>> Balbir, how would you want to do ? > >>> > >>> I planned to post shrink_uage patch later (it's easy to be implemented) regardless > >>> of acceptance of this patch. > >>> > >>> So, I think we should add shrink_usage now and drop this is a way to go. > >> I am a bit concerned about dropping stuff at will later. Ubuntu 8.10 has memory > >> controller enabled and we exposed memory.force_empty interface there and now > >> we've dropped it (bad on our part). I think we should have deprecated it and > >> dropped it later. > >> > > I *was* documented as "for debug only". > > > > I know, but I suspect users won't. I am not blaming you in person, just trying > the find way to do such things. I think I've seen sysfs add a deprecated option > and put all deprecated files there, they are only created if someone cares about > them. > Ah, but it should be done in cgroup layer. > > Hmm, adding force_empty again to do "shrink usage to 0" is another choice. > > Yes, sounds reasonable. > ok, will post a patch today. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org