From: Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"menage@google.com" <menage@google.com>
Subject: Re: [RFC][PATCH 4/6] memcg: swap cgroup for remembering account
Date: Wed, 12 Nov 2008 13:17:01 +0900 [thread overview]
Message-ID: <20081112131701.dbb7d003.d-nishimura@mtf.biglobe.ne.jp> (raw)
In-Reply-To: <20081112122949.d17bbc7f.kamezawa.hiroyu@jp.fujitsu.com>
> +/**
> + * lookup_swap_cgroup - lookup mem_cgroup tied to swap entry
> + * @ent: swap entry to be looked up.
> + *
> + * Returns pointer to mem_cgroup at success. NULL at failure.
> + */
> +struct mem_cgroup *lookup_swap_cgroup(swp_entry_t ent)
> +{
> + int type = swp_type(ent);
> + unsigned long flags;
> + unsigned long offset = swp_offset(ent);
> + unsigned long idx = offset / SC_PER_PAGE;
> + unsigned long pos = offset & SC_POS_MASK;
> + struct swap_cgroup_ctrl *ctrl;
> + struct page *mappage;
> + struct swap_cgroup *sc;
> + struct mem_cgroup *ret;
> +
> + if (!do_swap_account)
> + return NULL;
> +
> + ctrl = &swap_cgroup_ctrl[type];
> +
> + mappage = ctrl->map[idx];
> +
> + spin_lock_irqsave(&ctrl->lock, flags);
> + sc = kmap_atomic(mappage, KM_USER0);
> + sc += pos;
> + ret = sc->val;
> + kunmap_atomic(mapppage, KM_USER0);
s/mapppage/mappage
I don't know why I didn't notice this while testing previous version.
Thanks,
Daisuke Nishimura.
> + spin_unlock_irqrestore(&ctrl->lock, flags);
> + return ret;
> +}
> +
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-12 4:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 3:26 [RFC][PATCH 0/6] memcg updates (12/Nov/2008) KAMEZAWA Hiroyuki
2008-11-12 3:26 ` [RFC][PATCH 1/6] memcg: free all at rmdir KAMEZAWA Hiroyuki
2008-11-12 6:07 ` KAMEZAWA Hiroyuki
2008-11-13 0:07 ` Andrew Morton
2008-11-13 0:23 ` Balbir Singh
2008-11-13 0:46 ` Andrew Morton
2008-11-13 0:48 ` Balbir Singh
2008-11-13 1:04 ` Andrew Morton
2008-11-13 1:17 ` Balbir Singh
2008-11-13 2:30 ` KAMEZAWA Hiroyuki
2008-11-13 1:13 ` KAMEZAWA Hiroyuki
2008-11-13 1:20 ` Balbir Singh
2008-11-13 1:27 ` KAMEZAWA Hiroyuki
2008-11-13 2:49 ` KAMEZAWA Hiroyuki
2008-11-13 3:14 ` Balbir Singh
2008-11-13 3:22 ` KAMEZAWA Hiroyuki
2008-11-13 3:27 ` Balbir Singh
2008-11-13 3:38 ` KAMEZAWA Hiroyuki
2008-11-12 3:27 ` [RFC][PATCH 2/6] memcg: account swapcache KAMEZAWA Hiroyuki
2008-11-12 3:28 ` [RFC][PATCH 3/6] memcg: mem+swap controller kconfig KAMEZAWA Hiroyuki
2008-11-12 3:29 ` [RFC][PATCH 4/6] memcg: swap cgroup for remembering account KAMEZAWA Hiroyuki
2008-11-12 4:17 ` Daisuke Nishimura [this message]
2008-11-12 4:22 ` KAMEZAWA Hiroyuki
2008-11-12 3:30 ` [RFC][PATCH 5/6] memcg: mem+swap controller KAMEZAWA Hiroyuki
2008-11-12 3:32 ` [RFC][PATCH 6/6] memcg: synchronized LRU KAMEZAWA Hiroyuki
2008-11-12 3:33 ` [RFC][PATCH 0/6] memcg updates (12/Nov/2008) KAMEZAWA Hiroyuki
2008-11-12 4:00 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112131701.dbb7d003.d-nishimura@mtf.biglobe.ne.jp \
--to=d-nishimura@mtf.biglobe.ne.jp \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox