linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: npiggin@suse.de
From: Nick Piggin <npiggin@suse.de>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, glommer@redhat.com
Subject: [patch 2/7] mm: vmalloc failure flush fix
Date: Tue, 11 Nov 2008 00:35:17 +1100	[thread overview]
Message-ID: <20081110133840.706570000@suse.de> (raw)
In-Reply-To: <20081110133515.011510000@suse.de>

[-- Attachment #1: mm-vmalloc-flush-fix.patch --]
[-- Type: text/plain, Size: 1584 bytes --]

An initial vmalloc failure should start off a synchronous flush of lazy
areas, in case someone is in progress flushing them already, which could
cause us to return an allocation failure even if there is plenty of KVA
free.
 
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/mm/vmalloc.c
===================================================================
--- linux-2.6.orig/mm/vmalloc.c
+++ linux-2.6/mm/vmalloc.c
@@ -522,13 +522,24 @@ static void __purge_vmap_area_lazy(unsig
 }
 
 /*
+ * Kick off a purge of the outstanding lazy areas. Don't bother if somebody
+ * is already purging.
+ */
+static void try_purge_vmap_area_lazy(void)
+{
+	unsigned long start = ULONG_MAX, end = 0;
+
+	__purge_vmap_area_lazy(&start, &end, 0, 0);
+}
+
+/*
  * Kick off a purge of the outstanding lazy areas.
  */
 static void purge_vmap_area_lazy(void)
 {
 	unsigned long start = ULONG_MAX, end = 0;
 
-	__purge_vmap_area_lazy(&start, &end, 0, 0);
+	__purge_vmap_area_lazy(&start, &end, 1, 0);
 }
 
 /*
@@ -539,7 +550,7 @@ static void free_unmap_vmap_area(struct 
 	va->flags |= VM_LAZY_FREE;
 	atomic_add((va->va_end - va->va_start) >> PAGE_SHIFT, &vmap_lazy_nr);
 	if (unlikely(atomic_read(&vmap_lazy_nr) > lazy_max_pages()))
-		purge_vmap_area_lazy();
+		try_purge_vmap_area_lazy();
 }
 
 static struct vmap_area *find_vmap_area(unsigned long addr)

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-11-10 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 13:35 [patch 0/7] vmalloc fixes and improvements #2 npiggin
2008-11-10 13:35 ` [patch 1/7] mm: vmalloc allocator off by one npiggin, Nick Piggin
2008-11-10 13:35 ` npiggin, Nick Piggin [this message]
2008-11-10 13:35 ` [patch 3/7] mm: vmalloc search restart fix npiggin, Glauber Costa
2008-11-10 13:35 ` [patch 4/7] mm: vmalloc tweak failure printk npiggin, Glauber Costa
2008-11-10 13:35 ` [patch 5/7] mm: vmalloc improve vmallocinfo npiggin, Glauber Costa
2008-11-10 13:35 ` [patch 6/7] mm: vmalloc use mutex for purge npiggin, Nick Piggin
2008-11-10 13:35 ` [patch 7/7] mm: vmalloc make lazy unmapping configurable npiggin, Nick Piggin
2008-11-11 18:25 ` [patch 0/7] vmalloc fixes and improvements #2 Glauber Costa
2008-11-12  3:45   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081110133840.706570000@suse.de \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=glommer@redhat.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox