From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
glommer@redhat.com, rjw@sisk.pl
Subject: Re: [patch 0/9] vmalloc fixes and improvements
Date: Sat, 8 Nov 2008 06:41:44 +0100 [thread overview]
Message-ID: <20081108054144.GB24308@wotan.suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0811072109550.3468@nehalem.linux-foundation.org>
On Fri, Nov 07, 2008 at 09:13:38PM -0800, Linus Torvalds wrote:
>
>
> On Sat, 8 Nov 2008, npiggin@suse.de wrote:
> >
> > The following patches are a set of fixes and improvements for the vmap
> > layer.
>
> They seem seriously buggered.
>
> Patches that seem to be authorted by others (judging by sign-off) have no
> such attribution. And because you apparently use some sh*t-for-emailer,
> the patches that _are_ yours are missing your name, because it just says
>
> From: npiggin@suse.de
>
> without any "Nick Piggin" there.
>
> I'd suggest fixing your emailer scripts regardless, but a "From: " at the
> top of the body would fix both the attribution to others, and give you a
> name too.
I thought when there is no From in the body, then it defaults to the first
Signed-off-by:. At least Andrew's scripts IIRC have got that right? (unless
it is Andrew fixing it manually).
> PLEASE. Missing authorship attribution is seriously screwed up. Don't do
> it.
Don't merge them.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-08 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 2:15 npiggin
2008-11-08 2:15 ` [patch 1/9] mm: vmalloc allocator off by one npiggin
2008-11-08 2:15 ` [patch 2/9] mm: vmalloc failure flush fix npiggin
2008-11-08 2:15 ` [patch 3/9] mm: vmalloc search restart fix npiggin
2008-11-08 2:15 ` [patch 4/9] mm: vmalloc tweak failure printk npiggin
2008-11-08 2:15 ` [patch 5/9] mm: vmalloc improve vmallocinfo npiggin
2008-11-08 2:15 ` [patch 6/9] mm: vmalloc guard fix npiggin
2008-11-08 2:15 ` [patch 7/9] mm: vmalloc use mutex for purge npiggin
2008-11-08 2:15 ` [patch 8/9] mm: vmalloc make guard configurable npiggin
2008-11-08 2:15 ` [patch 9/9] mm: vmalloc make lazy unmapping configurable npiggin
2008-11-08 5:13 ` [patch 0/9] vmalloc fixes and improvements Linus Torvalds
2008-11-08 5:41 ` Nick Piggin [this message]
2008-11-08 15:00 ` Johannes Weiner
2008-11-09 2:15 ` Nick Piggin
2008-11-08 17:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108054144.GB24308@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=glommer@redhat.com \
--cc=linux-mm@kvack.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox