linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: npiggin@suse.de
To: akpm@linux-foundation.org, torvalds@linux-foundation.org
Cc: linux-mm@kvack.org, glommer@redhat.com, rjw@sisk.pl
Subject: [patch 8/9] mm: vmalloc make guard configurable
Date: Sat, 08 Nov 2008 13:15:20 +1100	[thread overview]
Message-ID: <20081108022014.313731000@nick.local0.net> (raw)
In-Reply-To: <20081108021512.686515000@suse.de>

[-- Attachment #1: mm-vmalloc-guard-config.patch --]
[-- Type: text/plain, Size: 1377 bytes --]

In mm/vmalloc.c, make usage of guard pages dependant on CONFIG_DEBUG_PAGEALLOC.

Signed-off-by: Glauber Costa <glommer@redhat.com>

Reworked so the guard size logic remains inside the allocator.

Signed-off-by: Nick Piggin <npiggin@suse.de>
---
 mm/vmalloc.c |   25 +++++++++++++++----------
 1 files changed, 15 insertions(+), 10 deletions(-)

Index: linux-2.6/mm/vmalloc.c
===================================================================
--- linux-2.6.orig/mm/vmalloc.c
+++ linux-2.6/mm/vmalloc.c
@@ -29,6 +29,16 @@
 #include <asm/uaccess.h>
 #include <asm/tlbflush.h>
 
+/*
+ * Add a guard page between each kernel virtual address allocation if
+ * DEBUG_PAGEALLOC is turned on (could be a separate config option, but
+ * no big deal).
+ */
+#ifdef CONFIG_DEBUG_PAGEALLOC
+#define GUARD_SIZE PAGE_SIZE
+#else
+#define GUARD_SIZE 0
+#endif
 
 /*** Page table manipulation functions ***/
 
@@ -364,7 +374,7 @@ retry:
 		}
 
 		while (addr + size > first->va_start && addr + size <= vend) {
-			addr = ALIGN(first->va_end + PAGE_SIZE, align);
+			addr = ALIGN(first->va_end + GUARD_SIZE, align);
 
 			n = rb_next(&first->rb_node);
 			if (n)

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-11-08  2:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  2:15 [patch 0/9] vmalloc fixes and improvements npiggin
2008-11-08  2:15 ` [patch 1/9] mm: vmalloc allocator off by one npiggin
2008-11-08  2:15 ` [patch 2/9] mm: vmalloc failure flush fix npiggin
2008-11-08  2:15 ` [patch 3/9] mm: vmalloc search restart fix npiggin
2008-11-08  2:15 ` [patch 4/9] mm: vmalloc tweak failure printk npiggin
2008-11-08  2:15 ` [patch 5/9] mm: vmalloc improve vmallocinfo npiggin
2008-11-08  2:15 ` [patch 6/9] mm: vmalloc guard fix npiggin
2008-11-08  2:15 ` [patch 7/9] mm: vmalloc use mutex for purge npiggin
2008-11-08  2:15 ` npiggin [this message]
2008-11-08  2:15 ` [patch 9/9] mm: vmalloc make lazy unmapping configurable npiggin
2008-11-08  5:13 ` [patch 0/9] vmalloc fixes and improvements Linus Torvalds
2008-11-08  5:41   ` Nick Piggin
2008-11-08 15:00     ` Johannes Weiner
2008-11-09  2:15       ` Nick Piggin
2008-11-08 17:37     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081108022014.313731000@nick.local0.net \
    --to=npiggin@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=glommer@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox