From: npiggin@suse.de
To: akpm@linux-foundation.org, torvalds@linux-foundation.org
Cc: linux-mm@kvack.org, glommer@redhat.com, rjw@sisk.pl
Subject: [patch 7/9] mm: vmalloc use mutex for purge
Date: Sat, 08 Nov 2008 13:15:19 +1100 [thread overview]
Message-ID: <20081108022014.203987000@nick.local0.net> (raw)
In-Reply-To: <20081108021512.686515000@suse.de>
[-- Attachment #1: mm-vmalloc-mutex.patch --]
[-- Type: text/plain, Size: 1692 bytes --]
The vmalloc purge lock can be a mutex so we can sleep while a purge is going
on (purge involves a global kernel TLB invalidate, so it can take quite a
while).
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/mm/vmalloc.c
===================================================================
--- linux-2.6.orig/mm/vmalloc.c
+++ linux-2.6/mm/vmalloc.c
@@ -14,6 +14,7 @@
#include <linux/highmem.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
+#include <linux/mutex.h>
#include <linux/interrupt.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
@@ -473,7 +474,7 @@ static atomic_t vmap_lazy_nr = ATOMIC_IN
static void __purge_vmap_area_lazy(unsigned long *start, unsigned long *end,
int sync, int force_flush)
{
- static DEFINE_SPINLOCK(purge_lock);
+ static DEFINE_MUTEX(purge_lock);
LIST_HEAD(valist);
struct vmap_area *va;
int nr = 0;
@@ -484,10 +485,10 @@ static void __purge_vmap_area_lazy(unsig
* the case that isn't actually used at the moment anyway.
*/
if (!sync && !force_flush) {
- if (!spin_trylock(&purge_lock))
+ if (!mutex_trylock(&purge_lock))
return;
} else
- spin_lock(&purge_lock);
+ mutex_lock(&purge_lock);
rcu_read_lock();
list_for_each_entry_rcu(va, &vmap_area_list, list) {
@@ -519,7 +520,7 @@ static void __purge_vmap_area_lazy(unsig
__free_vmap_area(va);
spin_unlock(&vmap_area_lock);
}
- spin_unlock(&purge_lock);
+ mutex_unlock(&purge_lock);
}
/*
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-08 2:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 2:15 [patch 0/9] vmalloc fixes and improvements npiggin
2008-11-08 2:15 ` [patch 1/9] mm: vmalloc allocator off by one npiggin
2008-11-08 2:15 ` [patch 2/9] mm: vmalloc failure flush fix npiggin
2008-11-08 2:15 ` [patch 3/9] mm: vmalloc search restart fix npiggin
2008-11-08 2:15 ` [patch 4/9] mm: vmalloc tweak failure printk npiggin
2008-11-08 2:15 ` [patch 5/9] mm: vmalloc improve vmallocinfo npiggin
2008-11-08 2:15 ` [patch 6/9] mm: vmalloc guard fix npiggin
2008-11-08 2:15 ` npiggin [this message]
2008-11-08 2:15 ` [patch 8/9] mm: vmalloc make guard configurable npiggin
2008-11-08 2:15 ` [patch 9/9] mm: vmalloc make lazy unmapping configurable npiggin
2008-11-08 5:13 ` [patch 0/9] vmalloc fixes and improvements Linus Torvalds
2008-11-08 5:41 ` Nick Piggin
2008-11-08 15:00 ` Johannes Weiner
2008-11-09 2:15 ` Nick Piggin
2008-11-08 17:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108022014.203987000@nick.local0.net \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=glommer@redhat.com \
--cc=linux-mm@kvack.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox