From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 7 Nov 2008 11:27:23 +0000 From: Mel Gorman Subject: Re: [RFC][PATCH] mm: the page of MIGRATE_RESERVE don't insert into pcp Message-ID: <20081107112722.GE13786@csn.ul.ie> References: <20081106091431.0D2A.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20081106164644.GA14012@csn.ul.ie> <20081107104224.1631057e.kamezawa.hiroyu@jp.fujitsu.com> <20081107104242.GC13786@csn.ul.ie> <20081107200251.15e9851a.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20081107200251.15e9851a.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro , LKML , Christoph Lameter , linux-mm List-ID: On Fri, Nov 07, 2008 at 08:02:51PM +0900, KAMEZAWA Hiroyuki wrote: > On Fri, 7 Nov 2008 10:42:42 +0000 > Mel Gorman wrote: > > > On Fri, Nov 07, 2008 at 10:42:24AM +0900, KAMEZAWA Hiroyuki wrote: > > > On Thu, 6 Nov 2008 16:46:45 +0000 > > > Mel Gorman wrote: > > > > > otherwise, the system have unnecessary memory starvation risk > > > > > because other cpu can't use this emergency pages. > > > > > > > > > > > > > > > > > > > > Signed-off-by: KOSAKI Motohiro > > > > > CC: Mel Gorman > > > > > CC: Christoph Lameter > > > > > > > > > > > > > This patch seems functionally sound but as Christoph points out, this > > > > adds another branch to the fast path. Now, I ran some tests and those that > > > > completed didn't show any problems but adding branches in the fast path can > > > > eventually lead to hard-to-detect performance problems. > > > > > > > dividing pcp-list into MIGRATE_TYPES is bad ? > > > > I do not understand what your question is. > > > Hmm. like this. > > pcp = &zone_pcp(zone, get_cpu())->pcp[migrate_type]; > Oh, do you mean splitting the list instead of searching? This is how it was originally implement and shot down on the grounds it increased the size of a per-cpu structure. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org