From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 7 Nov 2008 10:19:05 +0900 From: Daisuke Nishimura Subject: Re: [RFC][PATCH 4/6] memcg : swap cgroup Message-Id: <20081107101905.268533fb.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <29542.10.75.179.61.1225975461.squirrel@webmail-b.css.fujitsu.com> References: <20081105171637.1b393333.kamezawa.hiroyu@jp.fujitsu.com> <20081105172141.1a12dc23.kamezawa.hiroyu@jp.fujitsu.com> <20081106202534.80e5cf0a.nishimura@mxp.nes.nec.co.jp> <29542.10.75.179.61.1225975461.squirrel@webmail-b.css.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "menage@google.com" , nishimura@mxp.nes.nec.co.jp List-ID: On Thu, 6 Nov 2008 21:44:21 +0900 (JST), "KAMEZAWA Hiroyuki" wrote: > Daisuke Nishimura said: > > On Wed, 5 Nov 2008 17:21:41 +0900, KAMEZAWA Hiroyuki > > wrote: > >> Note1: In this, we use pointer to record information and this means > >> 8bytes per swap entry. I think we can reduce this when we > >> create "id of cgroup" in the range of 0-65535 or 0-255. > >> > >> Note2: array of swap_cgroup is allocated from HIGHMEM. maybe good for > >> x86-32. > >> > >> Signed-off-by: KAMEZAWA Hiroyuki > >> > >> include/linux/page_cgroup.h | 35 +++++++ > >> mm/page_cgroup.c | 201 > >> ++++++++++++++++++++++++++++++++++++++++++++ > >> mm/swapfile.c | 8 + > >> 3 files changed, 244 insertions(+) > >> > > Is there any reason why they are defined not in memcontrol.[ch] > > but in page_cgroup.[ch]? > > > no strong reason. just because this is not core logic for acccounting. > do you want to see this in memcontrol.c ? > I just felt strange just because they are not "page_cgroup". I don't have any strong request to move them to memcontrol.c. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org