From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id mA46ILW6030305 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 4 Nov 2008 15:18:21 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 03C0F45DD7B for ; Tue, 4 Nov 2008 15:18:21 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id D3F8D45DD7A for ; Tue, 4 Nov 2008 15:18:20 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id BC98A1DB803B for ; Tue, 4 Nov 2008 15:18:20 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.249.87.103]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 78E9C1DB803A for ; Tue, 4 Nov 2008 15:18:20 +0900 (JST) Date: Tue, 4 Nov 2008 15:17:48 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/5] memcg : force_empty to do move account Message-Id: <20081104151748.4731f5a1.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <6599ad830811032215j3ce5dcc1g6d0c3e9439a004d@mail.gmail.com> References: <20081031115057.6da3dafd.kamezawa.hiroyu@jp.fujitsu.com> <20081031115241.1399d605.kamezawa.hiroyu@jp.fujitsu.com> <6599ad830811032215j3ce5dcc1g6d0c3e9439a004d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Paul Menage Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , hugh@veritas.com, taka@valinux.co.jp List-ID: On Mon, 3 Nov 2008 22:15:41 -0800 Paul Menage wrote: > On Thu, Oct 30, 2008 at 6:52 PM, KAMEZAWA Hiroyuki > wrote: > > This patch provides a function to move account information of a page between > > mem_cgroups and rewrite force_empty to make use of this. > > One part of this that wasn't clear to me - if a cgroup has a lot of > unmapped pagecache sitting around but no tasks, and we try to rmdir > it, then all the pagecache gets moved to the parent too? Or just the > stray mapped pages? > All page caches will be moved to. (I'll add "shrink_usage" interface to drop page caches, later.) > > @@ -597,7 +709,7 @@ static int mem_cgroup_charge_common(stru > > prefetchw(pc); > > > > mem = memcg; > > - ret = mem_cgroup_try_charge(mm, gfp_mask, &mem); > > + ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, true); > > Isn't this the same as the definition of mem_cgroup_try_charge()? So > you could leave it as-is? > try_charge is called by other places....swapin. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org