From: Andrew Morton <akpm@linux-foundation.org>
To: Jianjun Kong <jianjun@zeuux.org>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH/RESEND] include/linux/mca-legacy.h: Fix the warning of note
Date: Tue, 28 Oct 2008 19:00:59 -0700 [thread overview]
Message-ID: <20081028190059.3d59fec7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081029014918.GA9649@ubuntu>
On Wed, 29 Oct 2008 09:49:18 +0800 Jianjun Kong <jianjun@zeuux.org> wrote:
> include/linux/mca-legacy.h: Fix the warning of note
When preparing patch changelogs, it is usually not sufficient to just
describe the change itself. Often that is obvious from the patch
itself, as in this case.
Instead, please take care to explain to us *why* a change was made.
> Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
> ---
> include/linux/mca-legacy.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mca-legacy.h b/include/linux/mca-legacy.h
> index 7a3aea8..e349f2b 100644
> --- a/include/linux/mca-legacy.h
> +++ b/include/linux/mca-legacy.h
> @@ -9,7 +9,7 @@
>
> #include <linux/mca.h>
>
> -#warning "MCA legacy - please move your driver to the new sysfs api"
> +/* warning "MCA legacy - please move your driver to the new sysfs api" */
>
> /* MCA_NOTFOUND is an error condition. The other two indicate
> * motherboard POS registers contain the adapter. They might be
Why was this change made?
As far as I can tell, the patch is wrong? Any driver which is using
the interfaces declared by mca-legacy.h should be changed to use the
sysfs API (whatever that is - I'm not sure).
So this warning should remain in place until all such drivers have been
converted to that API.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-10-29 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 1:49 Jianjun Kong
2008-10-29 2:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028190059.3d59fec7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jianjun@zeuux.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox