From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org
Subject: Re: [patch 2/3] swap: refactor pagevec flushing
Date: Sun, 26 Oct 2008 23:50:11 -0700 [thread overview]
Message-ID: <20081026235011.8af44857.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081022225512.879260477@saeurebad.de>
On Thu, 23 Oct 2008 00:50:08 +0200 Johannes Weiner <hannes@saeurebad.de> wrote:
> Having all pagevecs in one array allows for easier flushing. Use a
> single flush function that decides what to do based on the target LRU.
>
> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
> ---
> include/linux/pagevec.h | 13 +++--
> mm/swap.c | 121 +++++++++++++++++++++++-------------------------
> 2 files changed, 66 insertions(+), 68 deletions(-)
>
> --- a/include/linux/pagevec.h
> +++ b/include/linux/pagevec.h
> @@ -27,10 +27,13 @@ enum lru_pagevec {
> NR_LRU_PAGEVECS
> };
>
> +#define for_each_lru_pagevec(pv) \
> + for (pv = 0; pv < NR_LRU_PAGEVECS; pv++)
This only gets used once. I don't think it's existence is justified?
(`pv' is usally parenthesised in macros like this, but it's unlikely to
matter).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-27 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 22:50 [patch 0/3] activate pages in batch Johannes Weiner
2008-10-22 22:50 ` [patch 1/3] swap: use an array for all pagevecs Johannes Weiner
2008-10-22 22:50 ` [patch 2/3] swap: refactor pagevec flushing Johannes Weiner
2008-10-27 6:50 ` Andrew Morton [this message]
2008-10-27 8:08 ` Johannes Weiner
2008-10-27 12:18 ` [patch 2/3 v2] " Johannes Weiner
2008-10-22 22:50 ` [patch 3/3] swap: cache page activation Johannes Weiner
2008-10-23 1:41 ` [patch 0/3] activate pages in batch KOSAKI Motohiro
2008-10-23 2:00 ` Johannes Weiner
2008-10-23 2:10 ` KOSAKI Motohiro
2008-10-23 16:21 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026235011.8af44857.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@saeurebad.de \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox