From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: kosaki.motohiro@jp.fujitsu.com,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>,
Linux MM Mailing List <linux-mm@kvack.org>
Subject: Re: [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II
Date: Fri, 24 Oct 2008 21:55:44 +0900 (JST) [thread overview]
Message-ID: <20081024213527.492B.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <87zlkuj10z.fsf@saeurebad.de>
> mmotm:
> normal user: 1.775000s [0.053307] system: 9.620000s [0.135339] total: 98.875000s [0.613956]
> madvise user: 2.552500s [0.041307] system: 9.442500s [0.075980] total: 73.937500s [0.734170]
> mmotm+patch:
> normal user: 1.850000s [0.013540] system: 9.760000s [0.047081] total: 99.250000s [0.569386]
> madvise user: 2.547500s [0.014930] system: 8.865000s [0.055000] total: 71.897500s [0.144763]
>
> Well, time-wise not sooo much of an improvement. But given the
> massively decreased LRU-rotation [ http://hannes.saeurebad.de/madvseq/ ]
My first impression, this result mean the patch is not so useful.
But anyway, I mesured it again because I think Nick's opinion is very
reasonable and I don't know your mesurement condition so detail.
> I'm still looking forward to Kosaki-san's throughput measurements :)
I'm sorry for late responce.
but I'd like to you know this mesurement need spent long time in my time.
1. copybench (http://code.google.com/p/copybench/)
my machine mem: 8GB
target file size: 10GB (filesize > system mem)
mmotm-1022 + the patch
==============================================================
rw_cp 6:32 6:34
rw_fadv_cp 6:34 6:35
mm_sync_cp 6:15 6:16
mm_sync_madv_cp 6:19 6:14
mw_cp 6:11 6:12
mw_madv_cp 6:13 6:12
MADV_SEQUENTIAL decrease performance a bit on mmotm.
but the patch fix it.
2. MADV_SEQUENTIAL vs dbench
mmotm1022 + the patch
==============================================================
mm_sync_madv_cp 6:29 6:19 (min:sec)
dbench throughput 11.633 14.4045 (MB/s)
dbench latency 65628 18565 (ms)
mmotm's copy decrease performance largely. but the patch decrease it a bit.
dbench throuput improve about 25%, latency improve about 3.5 times.
So, I think the patch better than v1 and we should appreciate for Nick's
good suggestion.
Hanns, Actually I recomend to spent a bit more time for proper benchmark design and settings.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-24 12:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 10:32 [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Johannes Weiner
2008-10-21 10:43 ` Nick Piggin
2008-10-21 11:33 ` [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II Johannes Weiner
2008-10-21 22:13 ` Andrew Morton
2008-10-22 0:09 ` Johannes Weiner
2008-10-22 0:51 ` Johannes Weiner
2008-10-22 6:39 ` KOSAKI Motohiro
2008-10-22 7:15 ` Johannes Weiner
2008-10-22 7:41 ` Andrew Morton
2008-10-24 0:21 ` Johannes Weiner
2008-10-24 12:55 ` KOSAKI Motohiro [this message]
2008-10-24 14:02 ` Johannes Weiner
2008-10-24 14:31 ` Rik van Riel
2008-10-24 16:15 ` Johannes Weiner
2008-10-24 23:48 ` Johannes Weiner
2008-10-24 18:59 ` KOSAKI Motohiro
2008-10-21 14:40 ` [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Rik van Riel
2008-10-21 15:20 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024213527.492B.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@saeurebad.de \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox