From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id m9O4Sl8T019801 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Fri, 24 Oct 2008 13:28:48 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id A35E82AC02D for ; Fri, 24 Oct 2008 13:28:47 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 5796B12C04A for ; Fri, 24 Oct 2008 13:28:47 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 416F01DB803B for ; Fri, 24 Oct 2008 13:28:47 +0900 (JST) Received: from ml12.s.css.fujitsu.com (ml12.s.css.fujitsu.com [10.249.87.102]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id F12CF1DB8038 for ; Fri, 24 Oct 2008 13:28:46 +0900 (JST) Date: Fri, 24 Oct 2008 13:28:18 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 1/11] memcg: fix kconfig menu comment Message-Id: <20081024132818.6a211dd8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20081023212413.3182c1bb.randy.dunlap@oracle.com> References: <20081023175800.73afc957.kamezawa.hiroyu@jp.fujitsu.com> <20081023175946.8c67a51f.kamezawa.hiroyu@jp.fujitsu.com> <20081023212413.3182c1bb.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Randy Dunlap Cc: "linux-mm@kvack.org" , "balbir@linux.vnet.ibm.com" , "nishimura@mxp.nes.nec.co.jp" , "xemul@openvz.org" , "menage@google.com" List-ID: On Thu, 23 Oct 2008 21:24:13 -0700 Randy Dunlap wrote: > On Thu, 23 Oct 2008 17:59:46 +0900 KAMEZAWA Hiroyuki wrote: > > > Fixes menu help text for memcg-allocate-page-cgroup-at-boot.patch. > > > > > > Signed-off-by: KAMEZAWA hiroyuki > > > > init/Kconfig | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > Index: mmotm-2.6.27+/init/Kconfig > > =================================================================== > > --- mmotm-2.6.27+.orig/init/Kconfig > > +++ mmotm-2.6.27+/init/Kconfig > > @@ -401,16 +401,20 @@ config CGROUP_MEM_RES_CTLR > > depends on CGROUPS && RESOURCE_COUNTERS > > select MM_OWNER > > help > > - Provides a memory resource controller that manages both page cache and > > - RSS memory. > > + Provides a memory resource controller that manages both anonymous > > + memory and page cache. (See Documentation/controllers/memory.txt) > > > > Note that setting this option increases fixed memory overhead > > - associated with each page of memory in the system by 4/8 bytes > > - and also increases cache misses because struct page on many 64bit > > - systems will not fit into a single cache line anymore. > > + associated with each page of memory in the system. By this, > > + 20(40)bytes/PAGE_SIZE on 32(64)bit system will be occupied by memory > > + usage tracking struct at boot. Total amount of this is printed out > > + at boot. > > > > Only enable when you're ok with these trade offs and really > > - sure you need the memory resource controller. > > + sure you need the memory resource controller. Even when you enable > > + this, you can set "cgroup_disable=memory" at your boot option to > > + disable memoyr resource controller and you can avoid overheads. > > memory > Oh, I though I fixed this but not... Thank you for review! Regards, -Kame > > + (and lose benefits of memory resource contoller) > > > > This config option also selects MM_OWNER config option, which > > could in turn add some fork/exit overhead. > > > --- > ~Randy > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org