Re: [PATCH -mm 1/5] memcg: replace res_counter

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Tue, 21 Oct 2008 11:00:41 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > 1. It's harmful to increase size of *generic* res_counter. So, modifing
> >    res_counter only for us is not a choice.
> > 2. Operation should be done under a lock. We have to do 
> >    -page + swap in atomic, at least.
> > 3. We want to pack all member into a cache-line, multiple res_counter
> >    is no good.
> > 4. I hate res_counter ;)
> > 
> 
> What do you hate about it? I'll review the patchset in detail (I am currently
> unwell, but I'll definitely take a look later).
> 
Just because I feel this kind of *generic* counter can be an obstacle to
do aggressive special optimization for some resource. But I don't want to
argue this now. 

I'll rewrite and avoid to add new mem_counter. (and use 2 res_counters.)

Core logic will not be changed very much but....
Anyway, I'll go to the way which doesn't bother anyone.

BTW, "allocate all page_cgroup at boot" patch goes to Linus' git. Wow.

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>