linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Peter Cordes <peter@cordes.ca>
Cc: Hugh Dickins <hugh@veritas.com>, Bodo Eggert <7eggert@gmx.de>,
	David Newall <davidn@davidnewall.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: no way to swapoff a deleted swap file?
Date: Sat, 18 Oct 2008 07:18:01 +0200	[thread overview]
Message-ID: <20081018051800.GO24654@1wt.eu> (raw)
In-Reply-To: <20081018003117.GC26067@cordes.ca>

On Fri, Oct 17, 2008 at 09:31:17PM -0300, Peter Cordes wrote:
> On Fri, Oct 17, 2008 at 01:17:17PM +0100, Hugh Dickins wrote:
> > On Fri, 17 Oct 2008, Bodo Eggert wrote:
> > > 
> > > Somebody might want their swapfiles to have zero links,
> > > _and_ the possibility of doing swapoff.
> > 
> > You're right, they might, and it's not an unreasonable wish.
> > But we've not supported it in the past, and I still don't
> > think it's worth adding special kernel support for it now.
> 
>  I'd be inclined to agree with not bloating the kernel to support
> this, even though it would have been convenient for me in one case.  I
> do have an idea for supporting this without bloat, see below.  In case
> anyone wants more details about how I painted myself into that corner,
> here's the backstory to my feature request.

(...)
I have another idea which might be simpler to implement in userspace.
What happened to you is a typical accident, you did not run on purpose
on a deleted swap file. So we should at least ensure that such types
of accidents could not happen easily.

If swapon did set the immutable bit on a file just after enabling swap
to it, it would at least prevent accidental removal of that file. Swapoff
would have to clean that bit, and swapon would have to clean it upon
startup too (in case of unplanned reboots).

That way, you could still remove such files on purpose provided you do
a preliminary "chattr -i" on them, but "rm -rf" would keep them intact.
It would also prevent accidental modifications, such as "ls .>swapfile"
instead of "ls ./swapfile".

Regards,
Willy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-18  5:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bnlDw-5vQ-7@gated-at.bofh.it>
     [not found] ` <bnwpg-2EA-17@gated-at.bofh.it>
     [not found]   ` <bnJFK-3bu-7@gated-at.bofh.it>
2008-10-16 23:43     ` Bodo Eggert
2008-10-16 23:43     ` Bodo Eggert
     [not found]     ` <bnR0A-4kq-1@gated-at.bofh.it>
2008-10-17  8:20       ` Bodo Eggert
2008-10-17  8:20       ` Bodo Eggert
2008-10-17 12:17         ` Hugh Dickins
2008-10-17 12:36           ` David Newall
2008-10-17 22:42           ` Bodo Eggert
2008-10-18  0:31           ` Peter Cordes
2008-10-18  5:18             ` Willy Tarreau [this message]
2008-10-18 20:45               ` Hugh Dickins
2008-10-18 20:49                 ` Christoph Hellwig
2008-10-18 20:56                   ` Willy Tarreau
2008-11-14  2:37                     ` [PATCH 2.6.28?] don't unlink an active swapfile Hugh Dickins
2008-11-14  4:08                       ` Peter Cordes
2008-11-14 17:34                       ` Christoph Hellwig
2008-11-14 18:02                         ` Hugh Dickins
     [not found] <20081015202141.GX26067@cordes.ca>
2008-10-16  8:28 ` no way to swapoff a deleted swap file? Peter Zijlstra
2008-10-16 22:38   ` Hugh Dickins
2008-10-17  6:28     ` David Newall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081018051800.GO24654@1wt.eu \
    --to=w@1wt.eu \
    --cc=7eggert@gmx.de \
    --cc=davidn@davidnewall.com \
    --cc=hch@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peter@cordes.ca \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox