linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Chris Mason <chris.mason@oracle.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	cmm@us.ibm.com, sandeen@redhat.com, akpm@linux-foundation.org,
	hch@infradead.org, steve@chygwyn.com, npiggin@suse.de,
	mpatocka@redhat.com, linux-mm@kvack.org,
	inux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH updated] ext4: Fix file fragmentation during large file write.
Date: Wed, 15 Oct 2008 22:41:41 -0400	[thread overview]
Message-ID: <20081016024141.GA15487@mit.edu> (raw)
In-Reply-To: <1224114692.6938.48.camel@think.oraclecorp.com>

On Wed, Oct 15, 2008 at 07:51:32PM -0400, Chris Mason wrote:
> 
> Just FYI, I ran this with compilebench -i 20 --makej and my log is full
> of these:
> 
> ext4_da_writepages: jbd2_start: 1024 pages, ino 520417; err -30
> Pid: 4072, comm: pdflush Not tainted 2.6.27 #2

That's from ext4_journal_start_sb:

       if (sb->s_flags & MS_RDONLY)
       	  return ERR_PTR(-EROFS);

What was the very first error in your log?  It looks like ext4 somehow
flagged some kind of filesystem error or aborted the journal due to
some failure, and log gets filled these messages.  We should probably 
should throttle these messages by simply putting a

       if (sb->s_flags & MS_RDONLY)
		return -ERNOFS;

at the beginning of ext4_da_writepages() so we don't fill the logs
with extraneous messages that obscure more important error messages.

     			      	      	   	     - Ted

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-16  2:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-10 18:02 Aneesh Kumar K.V
2008-10-10 18:12 ` Aneesh Kumar K.V
2008-10-10 18:12 ` Aneesh Kumar K.V
2008-10-10 19:15 ` Chris Mason
2008-10-11 10:51 ` Nick Piggin
2008-10-11 18:14   ` Aneesh Kumar K.V
2008-10-11 19:07     ` Aneesh Kumar K.V
2008-10-15 20:41 ` Chris Mason
2008-10-15 23:51   ` Chris Mason
2008-10-16  2:41     ` Theodore Tso [this message]
2008-10-16  2:44     ` Andreas Dilger
2008-10-16  7:50     ` Aneesh Kumar K.V
2008-10-16  9:10     ` Aneesh Kumar K.V
2008-10-16 11:13       ` Aneesh Kumar K.V
2008-10-10 18:02 Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016024141.GA15487@mit.edu \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=chris.mason@oracle.com \
    --cc=cmm@us.ibm.com \
    --cc=hch@infradead.org \
    --cc=inux-fsdevel@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpatocka@redhat.com \
    --cc=npiggin@suse.de \
    --cc=sandeen@redhat.com \
    --cc=steve@chygwyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox