linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@saeurebad.de>
Subject: Re: mm-more-likely-reclaim-madv_sequential-mappings.patch
Date: Wed, 15 Oct 2008 23:31:26 -0700	[thread overview]
Message-ID: <20081015233126.27885bb9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081016151030.5832.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Thu, 16 Oct 2008 15:22:15 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > >                          2.6.27    mmotm-1010
> > >    ==============================================================
> > >    mm_sync_madv_cp       6:14      6:02         (min:sec)
> > >    dbench throughput     12.1507   14.6273      (MB/s)
> > >    dbench latency        33046     21779        (ms)
> > > 
> > > 
> > >    So, throughput improvement is relativily a bit, but latency improvement is much.
> > >    Then, I think the patch can improve "larege file copy (e.g. backup operation)
> > >    attacks desktop latency" problem.
> > > 
> > > Any comments?
> > > 
> > 
> > Sounds good.
> > 
> > But how do we know that it was this particular patch which improved the
> > latency performance?
> 
> In my concern,
> 
> dbench's pages are touched multiple times, but copy's pages are touched only twice.
> Then, on 2.6.27, copy's page transit to inactive -> active -> inactive -> free.
> it decrease latency meaninglessly.
> 
> IOW, 2.6.27 model
> 
> 1. shrink_inactive_lsit() promote copy's page to active (it touched twice (readahead + memcpy))
> 2. shrink_active_list() demote dbench's page
> 3. shrink_inactive_list() promote dbench's page (because it is touched multiple times)
> 4. shrink_active_list() demote copy's page
> 5. shrink_inactive_list() free copy's page
> 
> 
> mmotm mode,
> 
> 1, shrink_inactive_list() free copy's page.
> 2. end!

OK.  But my concern is that perhaps the above latency improvement was
caused by one of the many other MM patches in mmotm.

Reverting mm-more-likely-reclaim-madv_sequential-mappings.patch from
mmotm and rerunning the tests would be the way to determine this. 
(hint :) - thanks).


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-16  6:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 23:22 mm-more-likely-reclaim-madv_sequential-mappings.patch Andrew Morton
2008-10-16  1:30 ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16  6:01   ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16  6:06     ` mm-more-likely-reclaim-madv_sequential-mappings.patch Andrew Morton
2008-10-16  6:22       ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16  6:31         ` Andrew Morton [this message]
2008-10-16  6:38           ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16  8:07             ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16  6:09     ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-16 13:43 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-16 17:04   ` mm-more-likely-reclaim-madv_sequential-mappings.patch Rik van Riel
2008-10-17  2:21     ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-17  5:37       ` mm-more-likely-reclaim-madv_sequential-mappings.patch KOSAKI Motohiro
2008-10-17  5:56         ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-17 16:51       ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-18  1:30         ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-18 10:45           ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-19  2:21             ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-19  2:43               ` mm-more-likely-reclaim-madv_sequential-mappings.patch Rik van Riel
2008-10-19  2:58                 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin
2008-10-19 14:39               ` mm-more-likely-reclaim-madv_sequential-mappings.patch Johannes Weiner
2008-10-21  1:45                 ` mm-more-likely-reclaim-madv_sequential-mappings.patch Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081015233126.27885bb9.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox