From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Ingo Molnar <mingo@elte.hu>, Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
cl@linux-foundation.org
Subject: Re: [PATCH] Markers : revert synchronize marker unregister static inline (update)
Date: Fri, 10 Oct 2008 03:48:25 -0400 [thread overview]
Message-ID: <20081010074825.GF23247@Krystal> (raw)
In-Reply-To: <1223624589.8959.32.camel@penberg-laptop>
Use a #define for synchronize marker unregister to fix include dependencies.
Fixes the slab circular inclusion, where rcupdate includes slab, which
includes markers which includes rcupdate.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
CC: Ingo Molnar <mingo@elte.hu>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
CC: cl@linux-foundation.org
---
include/linux/marker.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
Index: linux-2.6-lttng/include/linux/marker.h
===================================================================
--- linux-2.6-lttng.orig/include/linux/marker.h 2008-10-10 03:28:03.000000000 -0400
+++ linux-2.6-lttng/include/linux/marker.h 2008-10-10 03:28:05.000000000 -0400
@@ -13,7 +13,6 @@
*/
#include <linux/types.h>
-#include <linux/rcupdate.h>
struct module;
struct marker;
@@ -166,9 +165,6 @@ extern void *marker_get_private_data(con
* unregistration and the end of module exit to make sure there is no caller
* executing a probe when it is freed.
*/
-static inline void marker_synchronize_unregister(void)
-{
- synchronize_sched();
-}
+#define marker_synchronize_unregister() synchronize_sched()
#endif
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-10 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 23:47 git-slab plus git-tip breaks i386 allnoconfig Andrew Morton
2008-10-10 0:03 ` Andrew Morton
2008-10-10 6:45 ` Pekka Enberg
2008-10-10 7:18 ` Mathieu Desnoyers
2008-10-10 7:23 ` Ingo Molnar
2008-10-10 7:37 ` [PATCH] Markers : revert synchronize marker unregister static inline Mathieu Desnoyers
2008-10-10 7:43 ` Pekka Enberg
2008-10-10 7:48 ` Mathieu Desnoyers [this message]
2008-10-10 8:36 ` [PATCH] Markers : revert synchronize marker unregister static inline (update) Ingo Molnar
2008-10-10 9:06 ` [PATCH] Markers : revert synchronize marker unregister static inline Ingo Molnar
2008-10-10 7:44 ` git-slab plus git-tip breaks i386 allnoconfig Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010074825.GF23247@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox