From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
cl@linux-foundation.org
Subject: Re: git-slab plus git-tip breaks i386 allnoconfig
Date: Fri, 10 Oct 2008 09:23:34 +0200 [thread overview]
Message-ID: <20081010072334.GA15715@elte.hu> (raw)
In-Reply-To: <20081010071815.GA23247@Krystal>
* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> * Pekka Enberg (penberg@cs.helsinki.fi) wrote:
> > Hi,
> >
> > On Thu, 2008-10-09 at 17:03 -0700, Andrew Morton wrote:
> > > OK, i386 allmodconfig is suffering something similar.
> > >
> > > In file included from include/linux/slub_def.h:13,
> > > from include/linux/slab.h:184,
> > > from include/linux/percpu.h:5,
> > > from include/linux/rcupdate.h:39,
> > > from include/linux/marker.h:16,
> > > from include/linux/module.h:18,
> > > from include/linux/crypto.h:21,
> > > from arch/x86/kernel/asm-offsets_32.c:7,
> > > from arch/x86/kernel/asm-offsets.c:2:
> > > include/linux/kmemtrace.h: In function 'kmemtrace_mark_alloc_node':
> > > include/linux/kmemtrace.h:33: error: implicit declaration of function 'trace_mark'
> > > include/linux/kmemtrace.h:33: error: 'kmemtrace_alloc' undeclared (first use in this function)
> > > include/linux/kmemtrace.h:33: error: (Each undeclared identifier is reported only once
> > > include/linux/kmemtrace.h:33: error: for each function it appears in.)
> > > include/linux/kmemtrace.h: In function 'kmemtrace_mark_free':
> > > include/linux/kmemtrace.h:44: error: 'kmemtrace_free' undeclared (first use in this function)
> > >
> > > I'll drop the slab tree.
> >
> > Oh, marker.h includes kmemtrace.h through dependencies... I'd argue
> > that's a marker.h bug; otherwise I don't see how we can use it in slab.
> > Mathieu?
> >
> > Pekka
> >
>
> (already sent privately to Ingo and Andrew)
>
> Ingo, can you simply revert commits
> 44c2a8c1cdf0f3374ef2f4f91db551527a336fb2
> "markers: turn marker_synchronize_unregister() into an inline"
> and
> "Tracepoints synchronize unregister static inline"
> (this last one does not seem to have hit -tip yet, but may be in -ftrace
> staging)
>
> That should fix the issue.
hm, could you please send a fix instead? I can revert from integration
branches temporarily but this needs a real fix.
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-10 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 23:47 Andrew Morton
2008-10-10 0:03 ` Andrew Morton
2008-10-10 6:45 ` Pekka Enberg
2008-10-10 7:18 ` Mathieu Desnoyers
2008-10-10 7:23 ` Ingo Molnar [this message]
2008-10-10 7:37 ` [PATCH] Markers : revert synchronize marker unregister static inline Mathieu Desnoyers
2008-10-10 7:43 ` Pekka Enberg
2008-10-10 7:48 ` [PATCH] Markers : revert synchronize marker unregister static inline (update) Mathieu Desnoyers
2008-10-10 8:36 ` Ingo Molnar
2008-10-10 9:06 ` [PATCH] Markers : revert synchronize marker unregister static inline Ingo Molnar
2008-10-10 7:44 ` git-slab plus git-tip breaks i386 allnoconfig Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010072334.GA15715@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox