From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Morton, Andrew" <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
Date: Wed, 8 Oct 2008 16:55:06 +1100 [thread overview]
Message-ID: <200810081655.06698.nickpiggin@yahoo.com.au> (raw)
This patch, like I said when it was first merged, has the problem that
it can cause large stalls when reclaiming pages.
I actually myself tried a similar thing a long time ago. The problem is
that after a long period of no reclaiming, your file pages can all end
up being active and referenced. When the first guy wants to reclaim a
page, it might have to scan through gigabytes of file pages before being
able to reclaim a single one.
While it would be really nice to be able to just lazily set PageReferenced
and nothing else in mark_page_accessed, and then do file page aging based
on the referenced bit, the fact is that we virtually have O(1) reclaim
for file pages now, and this can make it much more like O(n) (in worst case,
especially).
I don't think it is right to say "we broke aging and this patch fixes it".
It's all a big crazy heuristic. Who's to say that the previous behaviour
wasn't better and this patch breaks it? :)
Anyway, I don't think it is exactly productive to keep patches like this in
the tree (that doesn't seem ever intended to be merged) while there are
other big changes to reclaim there.
Same for vm-dont-run-touch_buffer-during-buffercache-lookups.patch
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2008-10-08 5:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 5:55 Nick Piggin [this message]
2008-10-08 10:03 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch KOSAKI Motohiro
2008-10-10 22:17 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Andrew Morton
2008-10-10 22:25 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Andrew Morton
2008-10-10 22:33 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Andrew Morton
2008-10-10 23:59 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Rik van Riel
2008-10-11 1:42 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Andrew Morton
2008-10-11 1:53 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Rik van Riel
2008-10-11 2:21 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Andrew Morton
2008-10-11 20:46 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Rik van Riel
2008-10-12 13:31 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch KOSAKI Motohiro
2008-10-10 23:56 ` vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810081655.06698.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox