From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 7 Oct 2008 17:10:49 +0200 From: Andi Kleen Subject: Re: [PATCH, RFC, v2] shmat: introduce flag SHM_MAP_HINT Message-ID: <20081007151049.GL20740@one.firstfloor.org> References: <20081006192923.GJ3180@one.firstfloor.org> <1223362670-5187-1-git-send-email-kirill@shutemov.name> <20081007082030.GD20740@one.firstfloor.org> <20081007100854.GA5039@localhost.localdomain> <20081007112631.GH20740@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andi Kleen , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Arjan van de Ven , Andrew Morton List-ID: On Tue, Oct 07, 2008 at 03:38:44PM +0100, Hugh Dickins wrote: > On Tue, 7 Oct 2008, Andi Kleen wrote: > > > I want say that we shouldn't do this check if shmaddr is a search hint. > > > I'm not sure that check is unneeded if shmadd is the exact address. > > > > mmap should fail in this case because it does the same check for > > MAP_FIXED. Obviously it cannot succeed when there is already something > > else there. > > I'm not really following this, so forgive me if I'm reading you > out of context, but I think you're wrong on that... You're right, Hugh, I was confused here. The earlier check is indeed needed and cannot be dropped. Thanks for the reality check. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org