Re: [PATCH 0/6] memcg update v6 (for review and discuss)

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Mon, 06 Oct 2008 22:56:20 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> KAMEZAWA Hiroyuki wrote:
> > On Wed, 1 Oct 2008 16:52:33 +0900
> > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > 
> >> This series is update from v5.
> >>
> >> easy 4 patches are already posted as ready-to-go-series.
> >>
> >> This is need-more-discuss set.
> >>
> >> Includes following 6 patches. (reduced from v5).
> >> The whole series are reordered.
> >>
> >> [1/6] make page_cgroup->flags to be atomic.
> >> [2/6] allocate all page_cgroup at boot.
> >> [3/6] rewrite charge path by charge/commit/cancel
> >> [4/6] new force_empty and move_account
> >> [5/6] lazy lru free
> >> [6/6] lazy lru add.
> >>
> >> Patch [3/6] and [4/6] are totally rewritten.
> >> Races in Patch [6/6] is fixed....I think.
> >>
> >> Patch [1-4] seems to be big but there is no complicated ops.
> >> Patch [5-6] is more racy. Check-by-regression-test is necessary.
> >> (Of course, I does some.)
> >>
> >> If ready-to-go-series goes, next is patch 1 and 2.
> >>
> > 
> > No terrible bugs until now on my test.
> > 
> > My current idea for next week is following.
> > (I may have to wait until the end of next merge window. If so, 
> >  I'll wait and maintain this set.)
> > 
> >  - post ready-to-go set again.
> >  - post 1/6 and 2/6 as may-ready-to-go set. I don't chagnge order of these.
> >  - reflects comments for 3/6. 
> >    patch 3/6 adds new functions. So, please tell me if you have better idea
> >    about new functions.
> >  - check logic for 4/6.
> >  - 5/6 and 6/6 may need some more comments in codes.
> >  - no new additional ones.
> 
> Kamezawa-San, Andrew,
> 
> I think patches 1 and 2 are ready to go. Andrew they remove the cgroup member
> from struct page and will help reduce the overhead for distros that care about
> 32 bit systems and also help with performance (in my runs so far).
> 
> I would recommend pushing 1 and 2 right away to -mm followed by the other
> performance improvements. Comments?
> 
> 

I'll rebase ready-to-go 4 patches and this 1 and 2 onto the latest mmotm
and send again.

Thank you for review.

Regards,
-Kame



> -- 
> 	Balbir
> 


-- 
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>